Bug 213218

Summary: www/gitlab: Multiple problems on "Issues" page
Product: Ports & Packages Reporter: Otacílio de Araújo Ramos Neto <otacilio.neto>
Component: Individual Port(s)Assignee: Torsten Zuehlsdorff <tz>
Status: Closed FIXED    
Severity: Affects Some People CC: vlad-fbsd
Priority: --- Keywords: needs-qa
Version: LatestFlags: bugzilla: maintainer-feedback? (tz)
Hardware: Any   
OS: Any   
Attachments:
Description Flags
gem list
none
pkg info none

Description Otacílio de Araújo Ramos Neto 2016-10-05 01:46:40 UTC
In the issue page the buttons "like", "dislike", "Add" don't works. Checking branches, Assignee, Milestone and Due Date stay rolling forever. I can't add comments to issues. The left side button menu don't works also.
gitlab 8.9.6_2.
Comment 1 Torsten Zuehlsdorff freebsd_committer freebsd_triage 2016-10-05 11:08:56 UTC
I'm currently in vacation and can have a look at this issue next week, sorry.

But some further requests:
- is this error new? was everything fine in 8.9.6_1?
- what is the result of: pkg info | grep rubygem-
- what is the result of: gem list

The result should be very long, but also helpful.

Thanks,
Torsten
Comment 2 Otacílio de Araújo Ramos Neto 2016-10-05 12:30:17 UTC
Created attachment 175446 [details]
gem list
Comment 3 Otacílio de Araújo Ramos Neto 2016-10-05 12:30:50 UTC
Created attachment 175447 [details]
pkg info
Comment 4 Otacílio de Araújo Ramos Neto 2016-10-05 12:32:16 UTC
Hello

I have migrated from gitlab-8.8.7, so I don't know if this problem occurs on 8.9.6_1.

The requested queries are attached.

Thanks a lot!
Comment 5 Otacílio de Araújo Ramos Neto 2016-10-11 12:23:13 UTC
Hello

Some news about this issue?

[]'s
-Otacilio
Comment 6 Torsten Zuehlsdorff freebsd_committer freebsd_triage 2016-10-12 10:25:10 UTC
No news, except that i'm back and onto it right now :)
Comment 7 Torsten Zuehlsdorff freebsd_committer freebsd_triage 2016-10-12 13:12:19 UTC
I nailed the problem down to the Rails 4.2.7.1 update which introduced the new turbo-links 5. Sadly GitLab needs turbo-links 2.5 and even the latest release will not work with version 5.
The solution is to bring back turbo-links 2.5 as new port and use it. Its not to hard, but will take some time.

If you need an urgent hotfix you can do:
# gem install turbo-links --version 2.5
# cd /usr/local/www/gitlab
# service gitlab stop
# rm Gemfile.lock
# vi Gemfile 

-> Now have a look for this line:
gem 'turbolinks', '>= 2.5.0'

And change it to:
gem 'turbolinks', '~> 2.5.0'

Afterwards do:
# rake assets:clean assets:precompile cache:clear RAILS_ENV=production
# service gitlab start

This will bring back the turbo-link javascript used for the buttons.
Comment 8 commit-hook freebsd_committer freebsd_triage 2016-10-13 10:00:03 UTC
A commit references this bug:

Author: tz
Date: Thu Oct 13 09:59:09 UTC 2016
New revision: 423907
URL: https://svnweb.freebsd.org/changeset/ports/423907

Log:
  Revive www/rubygem-turbolinks as www/rubygem-turbolinks-classic.

  turbolinks was completely rewritten and released as version 5.x. The old
  branch 2.5.x was renamed to turbolinks-classic.

  www/gitlab still depends on the old version of rubygem-turbolinks.
  Therefore its revived as a new port, while the updated turbolinks
  port will satisfy www/rubygem-rails4.

  PR:          213218
  Approved by: swills (mentor)

Changes:
  head/www/Makefile
  head/www/rubygem-turbolinks-classic/
  head/www/rubygem-turbolinks-classic/Makefile
  head/www/rubygem-turbolinks-classic/distinfo
  head/www/rubygem-turbolinks-classic/pkg-descr
Comment 9 commit-hook freebsd_committer freebsd_triage 2016-10-13 12:50:17 UTC
A commit references this bug:

Author: tz
Date: Thu Oct 13 12:49:34 UTC 2016
New revision: 423910
URL: https://svnweb.freebsd.org/changeset/ports/423910

Log:
  www/gitlab: Use www/rubygem-turbolinks-classic instead of www/rubygem-turbolinks

  This fixes various problems with the issue-pages of GitLab

  PR:          213218
  Approved by: junovitch (mentor, implicit)

Changes:
  head/www/gitlab/Makefile
  head/www/gitlab/files/patch-Gemfile
Comment 10 Torsten Zuehlsdorff freebsd_committer freebsd_triage 2016-10-13 13:01:35 UTC
Thanks for the report!
The issue should be fixed now! :)

For an update please follow this guide:
https://github.com/t-zuehlsdorff/gitlabhq/blob/master/doc/update/freebsd_patch_versions.md

It needs some time until there is a new binary package. If you need a quick update please use the ports-tree and make "cd /usr/ports/www/gitlab && make reinstall"

Greetings,
Torsten