Bug 213235

Summary: net-p2p/bitcoin: daemon startup script has problems
Product: Ports & Packages Reporter: Christopher Hall <hsw>
Component: Individual Port(s)Assignee: Marcelo Araujo <araujo>
Status: Closed FIXED    
Severity: Affects Only Me CC: araujo, robbak
Priority: --- Flags: bugzilla: maintainer-feedback? (robbak)
Version: Latest   
Hardware: amd64   
OS: Any   
Attachments:
Description Flags
Replacement startup script
none
patch to /usr/ports/[UG]IDs to add bitcoin user/group none

Description Christopher Hall 2016-10-06 03:04:40 UTC
Created attachment 175457 [details]
Replacement startup script

current startup script has following problems:

1. no option to set config file
2. no option to set datadir results in /.bitcoin which fills root directory
3. runs program in foreground as root which hang service start

suggest adding bitcoin as user/group to UIDs GIDs
the attached patches use 779 as this was a free id just before zetacoin.

A new status script template is attached.
Comment 1 Christopher Hall 2016-10-06 03:05:53 UTC
Created attachment 175458 [details]
patch to /usr/ports/[UG]IDs to add bitcoin user/group
Comment 2 Marcelo Araujo freebsd_committer freebsd_triage 2016-11-19 15:19:53 UTC
I will take it.
Comment 3 commit-hook freebsd_committer freebsd_triage 2016-11-25 06:11:51 UTC
A commit references this bug:

Author: araujo
Date: Fri Nov 25 06:11:02 UTC 2016
New revision: 427077
URL: https://svnweb.freebsd.org/changeset/ports/427077

Log:
  - Add a UID/GID for bitcoin.
  - Rewrite the rc script with new options that allows users to:
  	- set config file.
  	- set datadir.
  	- set bitcoin limits.

  PR:		ports/213235
  Submitted by:	Christopher Hall <hsw@bitmark.com>
  Approved by:	maintainer timeout (1 month)

Changes:
  head/GIDs
  head/UIDs
  head/net-p2p/bitcoin/Makefile
  head/net-p2p/bitcoin/files/bitcoind.in
Comment 4 Marcelo Araujo freebsd_committer freebsd_triage 2016-11-25 06:12:51 UTC
Committed, thanks!