Bug 213262

Summary: audio/sox: Play mode segfaults when releasing the device.
Product: Ports & Packages Reporter: Alexandros Perdikomatis <alexandrosperdikomatis>
Component: Individual Port(s)Assignee: Tobias Kortkamp <tobik>
Status: Closed FIXED    
Severity: Affects Some People CC: dnelson, tobik
Priority: --- Flags: tobik: maintainer-feedback+
Version: Latest   
Hardware: Any   
OS: Any   
URL: http://gnats.netbsd.org/cgi-bin/query-pr-single.pl?number=49929
Attachments:
Description Flags
sox.diff dnelson: maintainer-approval+

Description Alexandros Perdikomatis 2016-10-07 05:34:53 UTC 
sox play mode is doing fine if you Ctrl-C before file is finished playing, if you let it finish, results to a segmentation fault when releasing the device.
There is also a clip sound when taking the control of dsp when starting.
It seems kernel has a problem with the current libraries (Kernel 11.0-RC3) using standard port tree (the one comes with the release).
Comment 1 Tobias Kortkamp freebsd_committer freebsd_triage 2017-11-20 07:44:21 UTC 
Created attachment 188135 [details]
sox.diff

(In reply to Alexandros Perdikomatis from comment #0)

I can confirm the segfault.  Luckily there's a patch for it in pkgsrc
which seems to fix the problem.

I don't hear any clipping though when playback starts.
Comment 2 Dan Nelson 2017-11-20 16:12:55 UTC 
Comment on attachment 188135 [details]
sox.diff

This patch looks good.  Maintainer approved.
Comment 3 commit-hook freebsd_committer freebsd_triage 2017-11-20 20:35:29 UTC 
A commit references this bug:

Author: tobik
Date: Mon Nov 20 20:34:25 UTC 2017
New revision: 454577
URL: https://svnweb.freebsd.org/changeset/ports/454577

Log:
  audio/sox: Fix segfault in the OSS backend

  sox currently crashes when it finishes playing a file.

  PR:		213262
  Approved by:	Dan Nelson <dnelson@allantgroup.com> (maintainer)
  Reported by:	Alexandros Perdikomatis <alexandrosperdikomatis@gmail.com>
  Obtained from:	Pkgsrc
  MFH:		2017Q4

Changes:
  head/audio/sox/Makefile
  head/audio/sox/files/
  head/audio/sox/files/patch-src_oss.c
Comment 4 commit-hook freebsd_committer freebsd_triage 2017-11-20 21:06:02 UTC 
A commit references this bug:

Author: tobik
Date: Mon Nov 20 21:05:36 UTC 2017
New revision: 454580
URL: https://svnweb.freebsd.org/changeset/ports/454580

Log:
  MFH: r454577

  audio/sox: Fix segfault in the OSS backend

  sox currently crashes when it finishes playing a file.

  PR:		213262
  Approved by:	Dan Nelson <dnelson@allantgroup.com> (maintainer)
  Reported by:	Alexandros Perdikomatis <alexandrosperdikomatis@gmail.com>
  Obtained from:	Pkgsrc

  Approved by:	ports-secteam blanket

Changes:
_U  branches/2017Q4/
  branches/2017Q4/audio/sox/Makefile
  branches/2017Q4/audio/sox/files/
Comment 5 Tobias Kortkamp freebsd_committer freebsd_triage 2017-11-20 21:06:44 UTC 
(In reply to Dan Nelson from comment #2)
Committed. Thanks!