Summary: | x11-fonts/firacode: Update to 1.203 | ||||||
---|---|---|---|---|---|---|---|
Product: | Ports & Packages | Reporter: | Jamie Penman-Smithson <jpenman.smithson> | ||||
Component: | Individual Port(s) | Assignee: | freebsd-ports-bugs (Nobody) <ports-bugs> | ||||
Status: | Closed FIXED | ||||||
Severity: | Affects Some People | CC: | cs, dch | ||||
Priority: | --- | Keywords: | easy, needs-qa, patch | ||||
Version: | Latest | Flags: | vlad-fbsd:
maintainer-feedback+
|
||||
Hardware: | Any | ||||||
OS: | Any | ||||||
Attachments: |
|
Description
Jamie Penman-Smithson
2016-10-07 13:31:42 UTC
awesome! Given that people using this will only be on desktop systems, why not either: - drop the options completely & install all the formats by default - enable all the options by default Either is fine by me, so pick one and lets ship it. Interestingly I didn't get notified by portscout of the version change, thanks for picking this up. Overhead of a few new font files installed vs. overhead of having yet another port scream for attention, I vote drop the options. Please confirm the changes pass the build test (portlint, poudriere). I'm not sure how fontconfig determines which font to use if there are multiple types, these threads suggest it isn't deterministic: https://lists.freedesktop.org/archives/fontconfig/2008-July/002985.html https://www.tug.org/pipermail/tex-live/2012-April/031414.html So I'll update it to just include the OTF fonts and get rid of the options. (In reply to Jamie Penman-Smithson from comment #3) a gentle bump for your updated patch https://github.com/tonsky/FiraCode/releases/tag/1.204 is out, if jps has no time I'll pick this up end of the week. A commit references this bug: Author: cs Date: Sun Jan 1 14:14:39 UTC 2017 New revision: 430255 URL: https://svnweb.freebsd.org/changeset/ports/430255 Log: Update to 1.204 PR: 213272 Approved by: maintainer (via personal mail) Changes: head/x11-fonts/firacode/Makefile head/x11-fonts/firacode/distinfo |