Bug 213276

Summary: port 502 is officially mbap (Modbus Application Protocol), /etc/services claims outdated asa-appl-proto
Product: Base System Reporter: Mark.Martinec
Component: standardsAssignee: Alan Somers <asomers>
Status: Closed FIXED    
Severity: Affects Only Me CC: asomers, emaste, pi, rgrimes, vangyzen
Priority: --- Keywords: patch
Version: 11.0-STABLEFlags: asomers: mfc-stable11+
asomers: mfc-stable10+
Hardware: Any   
OS: Any   
Attachments:
Description Flags
patch for /etc/services: ports 502 and 802 none

Description Mark.Martinec 2016-10-07 14:49:07 UTC 
Created attachment 175500 [details]
patch for /etc/services: ports r502 and 802

The file /etc/services states that port 502 belongs to an asa-appl-proto
service, but this is not true. The port is officially (IANA) assigned
to "Modbus Application Protocol" since 2014-06-10. Apparently it was
previously assigned to Cisco, but no longer is. Also a related port 802
entry is missing in /etc/services.

http://www.iana.org/assignments/service-names-port-numbers/service-names-port-numbers.xhtml?search=modbus

mbap	502 tcp Modbus Application Protocol [modbus.org] [Dennis_Dube] 2014-06-10
mbap	502 udp Modbus Application Protocol [modbus.org] [Dennis_Dube] 2014-06-10
mbap-s	802 tcp Modbus Application Protocol Secure [modbus.org] [Dennis_Dube]
mbap-s	802 udp Modbus Application Protocol Secure [modbus.org] [Dennis_Dube]

See also: http://seclists.org/nmap-dev/2015/q3/373
Comment 1 Mark.Martinec 2017-07-31 15:06:38 UTC 
Any chance of getting this simple fix of /etc/services into CURRENT
before it's too late for 12.0 ...
Comment 2 Alan Somers freebsd_committer freebsd_triage 2018-08-17 15:08:12 UTC 
The change looks good to me.  Unfortunately, IANA doesn't seem to publish any revision control information.  But the wayback machine does.  Here's a snapshot from early 2014 showing that it was asa-appl-proto back then.

https://web.archive.org/web/20140423055003/http://www.iana.org/assignments/service-names-port-numbers/service-names-port-numbers.xhtml?&page=10
Comment 3 Rodney W. Grimes freebsd_committer freebsd_triage 2018-08-17 15:12:46 UTC 
Ed, FYI, I have requested an add for the release engineering check list that we check the files /etc/services and /etc/protocols at each release.  I had an earlier similar item added for ntp leapseconds file (11.2 went out with an out of date file :-().
Comment 4 Rodney W. Grimes freebsd_committer freebsd_triage 2018-08-17 15:14:11 UTC 
(In reply to Alan Somers from comment #2)
We should probably put a "last updated from:" in the file and pull this in just before each release branch (aka, ALPHA1 time is probably best).
Comment 5 Alan Somers freebsd_committer freebsd_triage 2018-08-17 15:15:41 UTC 
(In reply to Rodney W. Grimes from comment #4)

I'll look into doing that.  In the meantime, I'll commit this patch as-is.
Comment 6 commit-hook freebsd_committer freebsd_triage 2018-08-17 15:19:20 UTC 
A commit references this bug:

Author: asomers
Date: Fri Aug 17 15:18:58 UTC 2018
New revision: 337973
URL: https://svnweb.freebsd.org/changeset/base/337973

Log:
  Add Modbus Application Protocol to /etc/services

  IANA reassigned ports r502 and 802 on 2014-06-10

  PR:		213276
  Submitted by:	Mark.Martinec@ijs.si
  MFC after:	2 weeks

Changes:
  head/etc/services
Comment 7 Rodney W. Grimes freebsd_committer freebsd_triage 2018-08-17 15:51:27 UTC 
(In reply to Alan Somers from comment #5)
Thanks Alan, and on the MFC-stable10/11, yes please, from me with hat RE@.
Comment 8 commit-hook freebsd_committer freebsd_triage 2018-10-01 16:02:23 UTC 
A commit references this bug:

Author: asomers
Date: Mon Oct  1 16:01:21 UTC 2018
New revision: 339056
URL: https://svnweb.freebsd.org/changeset/base/339056

Log:
  MFC r337973:

  Add Modbus Application Protocol to /etc/services

  IANA reassigned ports r502 and 802 on 2014-06-10

  PR:		213276
  Submitted by:	Mark.Martinec@ijs.si

Changes:
_U  stable/11/
  stable/11/etc/services
Comment 9 commit-hook freebsd_committer freebsd_triage 2018-10-01 16:15:40 UTC 
A commit references this bug:

Author: asomers
Date: Mon Oct  1 16:14:39 UTC 2018
New revision: 339063
URL: https://svnweb.freebsd.org/changeset/base/339063

Log:
  MFC r337973:

  Add Modbus Application Protocol to /etc/services

  IANA reassigned ports r502 and 802 on 2014-06-10

  PR:		213276
  Submitted by:	Mark.Martinec@ijs.si

Changes:
_U  stable/10/
  stable/10/etc/services