Bug 213376

Summary: net-mgmt/librenms: Use mysqli instead of mysql php extension (support for PHP7)
Product: Ports & Packages Reporter: Fredrik Eriksson <fredrik.eriksson>
Component: Individual Port(s)Assignee: Muhammad Moinur Rahman <bofh>
Status: Closed FIXED    
Severity: Affects Only Me CC: bofh
Priority: --- Keywords: needs-qa, patch
Version: LatestFlags: bofh: maintainer-feedback+
Hardware: Any   
OS: Any   
Attachments:
Description Flags
Use mysqli-extension instead of mysql
none
Use mysqli-extension instead of mysql vlad-fbsd: maintainer-approval? (bofh)

Description Fredrik Eriksson 2016-10-11 12:04:06 UTC
Created attachment 175618 [details]
Use mysqli-extension instead of mysql

The librenms port requires the mysql extension, which has been removed in php7. As such it is not possible to build the librenms port with DEFAULT_VERSIONS=php=7.0.

However, it seems librenms can use either one of mysql or mysqli, so this patch simply replaces the mysql requirement with mysqli.

Note that I'm building this port for someone else (who will look at it "in due time"), so I haven't tested that the package actually works after this patch, but it builds successfully in poudriere and since the official librenms images uses PHP7 I'm pretty sure this shouldn't be a problem (but should still be tested of course).
Comment 1 Fredrik Eriksson 2016-10-11 16:47:06 UTC
Created attachment 175630 [details]
Use mysqli-extension instead of mysql

Sorry, a paste-fail messed up tabs in previous patch, attaching a new.
Comment 2 VK freebsd_triage 2016-10-11 18:04:19 UTC
Comment on attachment 175630 [details]
Use mysqli-extension instead of mysql

Thanks for the patch. Please set the maintainer-approval request (?) on attachments for ports you're not maintainer of (under attachment details, flags), as that way the maintainers can approve your patches.