Bug 213407
| Summary: | www/grafana3: Update to 3.1.1 | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | John Hixson <jhixson> | ||||||||||||
| Component: | Individual Port(s) | Assignee: | Palle Girgensohn <girgen> | ||||||||||||
| Status: | Closed FIXED | ||||||||||||||
| Severity: | Affects Only Me | CC: | girgen, john, wac | ||||||||||||
| Priority: | --- | Keywords: | patch | ||||||||||||
| Version: | Latest | Flags: | koobs:
maintainer-feedback+
|
||||||||||||
| Hardware: | Any | ||||||||||||||
| OS: | Any | ||||||||||||||
| Attachments: |
|
||||||||||||||
|
Description
John Hixson
2016-10-12 07:09:48 UTC
Created attachment 175651 [details]
bzipped grafana3 shar file
Shar file was 3MB to I bzipped it.
Created attachment 175652 [details]
bzipped grafana3 shar file
@John, can you please update your Bugzilla email address to match the MAINTAINER line in the grafana3 port, or alternatively update the MAINTAINER line in the port to match your Bugzilla email address. If the former, you will then be able to set the maintainer-feedback flag value to +. These both need to match in order for auto-assignment to correctly function and to validate/confirm that authors of patches are indeed from (and therefore implicitly approved by) the maintainer that is set. Also: Port updates need to be in unified diff (preferably svn diff) format. shell archives are only for use with the creation of new ports (and even then, unified diffs are also allowed) Please confirm these changes pass QA (portlint, poudriere, etc). For more information, see: https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/testing.html Created attachment 175763 [details]
poudriere output
Addint portlint and poudriere output since John does not respond
www/grafana3]# portlint
WARN: Makefile: possible use of absolute pathname "/var/db/${PORTNAME}/".
WARN: Makefile: possible use of absolute pathname "/var/log/${PORTNAME}...".
WARN: Makefile: possible use of absolute pathname "/var/run/${PORTNAME}...".
WARN: Makefile: possible use of absolute pathname "/var/db/${PORTNAME}/...".
WARN: Makefile: possible use of absolute pathname "/var/db/${PORTNAME}/...".
0 fatal errors and 5 warnings found.
Created attachment 175764 [details]
diff format of the supplied shar
once we hear from john and this can be committed with the new maintainer email, we should commit PR ports/213355 as well. Comment on attachment 175764 [details]
diff format of the supplied shar
Thank you Palle. Is the diff not small enough (< 1mb) to be attached without compression?
Also, setting [x] patch for non-plaintext attachments causes failure in rendering. fwiw, setting [x] patch does not mean 'this is a patch type attachment' (counter-intuitively)
(In reply to Kubilay Kocak from comment #7) The patch was > 1MB, yes. I've been testing the port in production and it seems the new Alerting stuff is not working. This could of course be a problem from upstreams, just checking here before reaching out to the Grafana community. I get 404 file not found when clicking the Alert tab for a query. This is for path=/api/alert-notifications and stuff under /api/alerts/... @john, does this work for you? Created attachment 175891 [details]
grafana3 port diff
Diff to old port. I have already changed maintainer to my gmail address.
(In reply to Palle Girgensohn from comment #9) It looks like the same thing is happening to me. I can reproduce the issue. I will look further into it. [auth.google] settings are not working for using the attached diff. I'm not sure if this is an upstream problem or not. So, this works for a great part, should we commit this or try to get the problems fixed? tldr; Unless contrary/alternative instructions are otherwise explicitly provided by those responsible (committer, maintainer, reporter), issues will always progress as per their 'current state'. In it's current state this issue has a change (attachment) supplied with maintainer approval (implicitly as submitter is maintainer). Unless otherwise changed by the maintainer, for example by obsoleting the existing patch because they are investigating (see comment 11), this issue and it's change will proceed as is. @John please modify the issue's status explicitly if the above action does not suit what you want. Also, please obsolete all changes (attachments) that are no longer relevant, except those which you are happy for someone to commit at any time. Kubilay, I haven't had time to look into this and probably won't for another week or two. I am happy to accept the diff from Palle if it works. - John A commit references this bug: Author: girgen Date: Thu Oct 27 14:31:09 UTC 2016 New revision: 424768 URL: https://svnweb.freebsd.org/changeset/ports/424768 Log: Update Grafana to 3.1.1 Fix problem with rc.script as well. Approved by: maintainer PR: 213355, 213407 Changes: head/www/grafana3/Makefile head/www/grafana3/distinfo head/www/grafana3/files/grafana3.in head/www/grafana3/pkg-plist Committed. The 404 for the brand new alert notifications is an upstream problem. I either case, all the old behaviour is working great, would be sad not to use the new version. Assign to committer that resolved. @Girgen Please assign issues you intend to work on & commit so that: - It doesn't look like a drive by - Work is not duplicated - Issue fields correctly reflect the state of what happened, when and by who. (In reply to Kubilay Kocak from comment #18) Ah sorry! Will do! Palle A commit references this bug: Author: feld Date: Fri Oct 28 13:57:56 UTC 2016 New revision: 424848 URL: https://svnweb.freebsd.org/changeset/ports/424848 Log: MFH: r424768 r424769 Update Grafana to 3.1.1 Fix problem with rc.script as well. Approved by: maintainer PR: 213355, 213407 Add extra patch for the rc script Submitted by: Andy Carrel PR: 213355 Approved by: ports-secteam (with hat) Changes: _U branches/2016Q4/ branches/2016Q4/www/grafana3/Makefile branches/2016Q4/www/grafana3/distinfo branches/2016Q4/www/grafana3/files/grafana3.in branches/2016Q4/www/grafana3/pkg-plist |