Bug 213517

Summary:

audio/raop_play: Fix build with libc++ 3.9.0

Product:

Ports & Packages

Reporter:

Dimitry Andric <dim>

Component:

Individual Port(s)

Assignee:

Thomas Zander <riggs>

Status:

Closed FIXED

Severity:

Affects Some People

CC:

riggs

Priority:

---

Keywords:

easy, patch

Version:

Latest

Flags:

riggs: merge-quarterly+

Hardware:

Any

OS:

Any

Bug Depends on:

Bug Blocks:

212343

Attachments:

Description	Flags
Use correct type for strstr() return value	none

Description Dimitry Andric freebsd_committer

2016-10-15 22:52:27 UTC

Created attachment 175799 [details]
Use correct type for strstr() return value

During the exp-run for bug 212343, audio/raop_play failed to build, because strstr() on a const string now returns a const string too:

aexcl_play.cxx:209:11: error: assigning to 'char *' from incompatible type 'const char *'
        if(!(astr=strstr(rargv[1],IP_NAME_DELIM))) return -1;
                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

This can easily be fixed by making astr a const char *.

Comment 1 commit-hook freebsd_committer

2016-10-22 13:32:54 UTC

A commit references this bug:

Author: riggs
Date: Sat Oct 22 13:32:11 UTC 2016
New revision: 424472
URL: https://svnweb.freebsd.org/changeset/ports/424472

Log:
  Fix build with libc++ 3.9.0

  PR:		213517
  Submitted by:	dim
  MFH:		2016Q4 (ports-secteam build fix blanket)

Changes:
  head/audio/raop_play/files/patch-aexcl_aexcl__play.cxx

Comment 2 commit-hook freebsd_committer

2016-10-22 13:37:55 UTC

A commit references this bug:

Author: riggs
Date: Sat Oct 22 13:37:08 UTC 2016
New revision: 424473
URL: https://svnweb.freebsd.org/changeset/ports/424473

Log:
  MFH: r424472

  Fix build with libc++ 3.9.0

  PR:		213517
  Submitted by:	dim

  Approved by:	ports-secteam (build fix blanket)

Changes:
_U  branches/2016Q4/
  branches/2016Q4/audio/raop_play/files/patch-aexcl_aexcl__play.cxx