Bug 213632
| Summary: | [NEW PORT] devel/arduino-libastylej: Patched version of libastylej to be used by the Arduino IDE | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Kyle Evans <kevans> | ||||
| Component: | Individual Port(s) | Assignee: | Boris Samorodov <bsam> | ||||
| Status: | Closed FIXED | ||||||
| Severity: | Affects Only Me | CC: | bsam | ||||
| Priority: | --- | Keywords: | feature, needs-qa | ||||
| Version: | Latest | ||||||
| Hardware: | Any | ||||||
| OS: | Any | ||||||
| Bug Depends on: | 213631 | ||||||
| Bug Blocks: | 213659 | ||||||
| Attachments: |
|
||||||
Take. @Kyle Note that unified diffs (preferably svn diff) are also (now) allowed for new ports. For this and future issues, confirmation of successful QA (portlint, poudriere) passing would also be appreciated (attaching logs is not required) (In reply to Kubilay Kocak from comment #2) @koobs: Noted, thank you. For reference, portlint did not like this at all because of the lack of...well, almost all information. The things that do exist were shoved into the PORTNAME= section, but I let this slave port inherit everything from the master port and PKGNAMEPREFIX= it to be unique. Should I have done this part differently? Also, fixed the non-fetching problem of the master port in the dependency PR #213631 -- I had assumed a basic 'works fine' from devel/libastylej being fine and `make package` yielding the results I expected. It didn't necessarily help that I already had the astyle distfile fetched from devel/astyle. A commit references this bug: Author: bsam Date: Fri Oct 21 22:41:41 UTC 2016 New revision: 424439 URL: https://svnweb.freebsd.org/changeset/ports/424439 Log: Fairly straightforward slave port of devel/libastylej that applies the Arduino-specific patches to the used JNI functions. Sets PKGNAMESUFFIX to get lib/jni/libastyle-arduinoj.so and sets the PATCH{DIR, _WRKSRC} variables to use the Arduino patches. PR: 213632 Submitted by: Kyle Evans <bsdports@kyle-evans.net> Changes: head/devel/Makefile head/devel/libastylej-arduino/ head/devel/libastylej-arduino/Makefile head/devel/libastylej-arduino/files/ head/devel/libastylej-arduino/files/patch-src_astyle__main.cpp head/devel/libastylej-arduino/files/patch-src_astyle__main.h Committed, thanks! |
Created attachment 175955 [details] shar(1) archive of devel/arduino-libastylej Fairly straightforward slave port of devel/libastylej that applies the Arduino-specific patches to the used JNI functions. Sets PKGNAMEPREFIX to get lib/jni/arduino-libastylej.so and sets the PATCH{DIR,_WRKSRC} variables to use the Arduino patches. Worth noting: I've created this shar(1) archive from the root of the ports tree to include CATEGORY/, unlike my previous submissions, on the advice of feld@ for good practice.