Summary: | devel/simgear version 2016.3.1 can cause flightgear to crash with assertion failure when changing radio frequencies | ||||||
---|---|---|---|---|---|---|---|
Product: | Ports & Packages | Reporter: | russo | ||||
Component: | Individual Port(s) | Assignee: | Ganael LAPLANCHE <martymac> | ||||
Status: | Closed FIXED | ||||||
Severity: | Affects Only Me | CC: | russo | ||||
Priority: | --- | Flags: | bugzilla:
maintainer-feedback?
(martymac) |
||||
Version: | Latest | ||||||
Hardware: | Any | ||||||
OS: | Any | ||||||
Attachments: |
|
Description
russo
2016-10-20 17:18:56 UTC
I should note that because the simgear port produces only static libraries, after the patch is applied and the port rebuilt, one also has to rebuild and reinstall flightgear to get the fix. A commit references this bug: Author: martymac Date: Mon Oct 24 10:13:50 UTC 2016 New revision: 424558 URL: https://svnweb.freebsd.org/changeset/ports/424558 Log: Backport radio bug patch from upstream PR: 213650 Submitted by: russo@bogodyn.org Changes: head/devel/simgear/Makefile head/devel/simgear/files/ head/devel/simgear/files/patch-simgear-sound-soundmgr_openal.cxx head/games/flightgear/Makefile Hi, Thanks a lot for your patch, it has been committed with a few changes as the patch provided didn't match exactly the changes brought by b9deeb and a97c14: the return statement should be outside the #ifdef/#endif block. Regards, Ganael. Egad. I saw that the return statement was supposed to be outside the ifdef/endif (it is the entire point of commit a97c14), and then goofed myself when applying the change by hand to produce my patch. I'm sorry it wasn't correct. But thanks for catching that and merging the change. No pb! Thanks to you :) |