Bug 213693
| Summary: | www/node: Copy to www/node6 (LTS version) | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Eric Camachat <eric> | ||||||||||
| Component: | Individual Port(s) | Assignee: | Kurt Jaeger <pi> | ||||||||||
| Status: | Closed FIXED | ||||||||||||
| Severity: | Affects Only Me | CC: | adamw, bhughes, koobs, pi | ||||||||||
| Priority: | --- | Keywords: | patch-ready | ||||||||||
| Version: | Latest | Flags: | bhughes:
maintainer-feedback+
|
||||||||||
| Hardware: | Any | ||||||||||||
| OS: | Any | ||||||||||||
| URL: | https://nodejs.org/en/blog/release/v6.9.0/ | ||||||||||||
| See Also: | https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=213604 | ||||||||||||
| Bug Depends on: | 213604, 214386 | ||||||||||||
| Bug Blocks: | 213945, 213947 | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Eric Camachat
2016-10-21 23:10:00 UTC
I see that the new port is at 6.9.1, but I'm still waiting for 213604 to be committed. Once that's done, I am all for this :) Comment on attachment 176047 [details]
clone www/node to www/node6 for new LTS
Patch needs updating now to pick up the changes I made to the www/node/Makefile in #213604.
Thanks much, this was my next TODO item, but now I can go straight to adding www/node7 :)
Created attachment 176335 [details]
node6-6.9.1
I decided to add my own patch here, instead of creating a new, duplicated issue:
--
www/node6: Copy from www/node
Create a new port for the latest Node.js LTS release. Like www/node4,
this allows users/ports to depend on a specific major version.
The patch-node.gyp file has not been copied, as the problem this patch
addresses has been fixed upstream. Patches have been refreshed with
`make makepatch`.
Created attachment 176399 [details]
www/node6, updated
portlint: OK (-AC, spurious warning about possible direct use of "python")
testport: OK (poudriere: 11.0-R, 10.[123]-R, 9.3-R, amd64/i386, default options)
testport: OK (poudriere: 11.0-R, 10.[123]-R, 9.3-R, amd64/i386, BUNDLED_SSL)
Created attachment 176876 [details]
www/node6: Copy from www/node
Create a new port for the latest Node.js LTS release. Like www/node4,
this allows users/ports to depend on a specific major version.
The patch-node.gyp file has not been copied, as the problem this patch
addresses has been fixed upstream. Patches have been refreshed with
`make makepatch`.
Update CONFLICTS_INSTALL for all www/node* ports.
Comment on attachment 176876 [details]
www/node6: Copy from www/node
portlint: OK (-AC, spurious warning about possible direct use of "python")
testport: OK (poudriere: 11.0-R, 10.[123]-R, 9.3-R, amd64/i386, default options)
testport: OK (poudriere: 11.0-R, 10.[123]-R, 9.3-R, amd64/i386, BUNDLED_SSL)
This behaves strange when it comes to download the distfile: $ make fetch ===> License MIT accepted by the user ===> node6-6.9.1 depends on file: /usr/local/sbin/pkg - found => node-v6.9.1.tar.gz doesn't seem to exist in /home/pi/m/distfiles/. => Attempting to fetch http://nodejs.org/dist/v6.9.1/node-v6.9.1.tar.gz fetch: 26504341: No such file or directory node-v6.9.1.tar.gz 100% of 25 MB 594 kBps 00m43s => Attempting to fetch http://distcache.FreeBSD.org/ports-distfiles/node-v6.9.1.tar.gz fetch: 26504341: No such file or directory => Couldn't fetch it - please try to retrieve this Any idea why that happens ? MASTER_SITE has some additional size field which somehow gets mangled into the filename. That seems to be the cause: node-v6.9.1.tar.gz 19-Oct-2016 22:02 26504341 Bradley, maybe the node ports should be fetching sources from Github? I cannot reproduce this: $ make distclean ===> Cleaning for node6-6.9.1 ===> Deleting distfiles for node6-6.9.1 $ make fetch ===> License MIT accepted by the user ===> node6-6.9.1 depends on file: /usr/local/sbin/pkg - found => node-v6.9.1.tar.gz doesn't seem to exist in /usr/ports/distfiles/. => Attempting to fetch http://nodejs.org/dist/v6.9.1/node-v6.9.1.tar.gz node-v6.9.1.tar.gz 100% of 25 MB 14 MBps 00m01s ===> Fetching all distfiles required by node6-6.9.1 for building $ (In reply to Adam Weinberger from comment #9) Adam: I have considered it. The distinfo file was twice the same lines. This seems to be the cause. ------------ TIMESTAMP = 1476953621 SHA256 (node-v6.9.1.tar.gz) = a98997ca3a4d10751f0ebe97839b2308a31ae884b4203cda0c99cf36bc7fe3bf SIZE (node-v6.9.1.tar.gz) = 26504341 TIMESTAMP = 1476953621 SHA256 (node-v6.9.1.tar.gz) = a98997ca3a4d10751f0ebe97839b2308a31ae884b4203cda0c99cf36bc7fe3bf SIZE (node-v6.9.1.tar.gz) = 26504341 ------------ testbuilds@work Well, pkg-plist, pkg-message and pkg-descr were duplicated, too. Duplicated how? The patch I added doesn't show any duplicated lines. Like distinfo: same contents added to the file after the first instance. Really strange. A commit references this bug: Author: pi Date: Sat Nov 19 12:21:23 UTC 2016 New revision: 426362 URL: https://svnweb.freebsd.org/changeset/ports/426362 Log: www/node: Copy to www/node6 as LTS version PR: 213693 Submitted by: Bradley T. Hughes <bradleythughes@fastmail.fm> (maintainer) Changes: head/www/Makefile head/www/node/Makefile head/www/node012/Makefile head/www/node4/Makefile head/www/node6/ head/www/node6/Makefile head/www/node6/files/patch-deps_v8_src_arm_cpu-arm.cc head/www/node6/files/patch-deps_v8_src_base_atomicops__internals__arm__gcc.h head/www/node6/files/patch-deps_v8_src_base_platform_platform-freebsd.cc head/www/node6/files/patch-deps_v8_src_log-utils.h head/www/node6/files/patch-deps_v8_src_profiler_sampler.cc Committed, thanks! Thanks Kurt :) |
