Bug 213783

Summary:

net/wpa_gui: Missing dependency: qt4-imageformats

Product:

Ports & Packages

Reporter:

rsos+freebsd

Component:

Individual Port(s)

Assignee:

Jason E. Hale <jhale>

Status:

Closed FIXED

Severity:

Affects Some People

CC:

jhale

Priority:

---

Keywords:

easy, needs-patch, needs-qa

Version:

Latest

Flags:

koobs: merge-quarterly?

Hardware:

Any

OS:

Any

See Also:

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=213782

Attachments:

Description	Flags
patch that adds imageformats to dependencies	none

Description rsos+freebsd 2016-10-25 20:39:53 UTC

Hello,

thanks for providing this port! Today I noticed that I don't see any icons in the icon bar (zoom, jump to next page, etc.) are missing as long the package qt4-iconengines is not additionally installed. Maybe it may be useful to add it to the dependency list.

This is related to bug #213782.

Greetings

Comment 1 rsos+freebsd 2016-10-27 14:37:02 UTC

Hello again,

I'm sorry I was a bit too fast in commiting this bug. The missing dependency is qt4-imageformats. Without this package the tray icon is not correctly shown.

Thanks!

Comment 2 Kubilay Kocak freebsd_committer

2016-10-27 15:04:48 UTC

@rs.os This port does not currently have a maintainer. If you could provide a patch to address the issue in question, that would be great.

Comment 3 rsos+freebsd 2016-11-02 11:13:14 UTC

Created attachment 176417 [details]
patch that adds imageformats to dependencies

Hello,

attached you will find the patch. Unfortunately, I couldn't test it properly because my machine is too slow to build all the dependencies. But the changes aren't too complex ;-)

Comment 4 commit-hook freebsd_committer

2016-11-03 09:18:09 UTC

A commit references this bug:

Author: jhale
Date: Thu Nov  3 09:18:04 UTC 2016
New revision: 425197
URL: https://svnweb.freebsd.org/changeset/ports/425197

Log:
  Add qt4-imageformats runtime dependency so tray icon appears

  While here:
  Remake patches with "make makepatch"

  PR:		213783
  Submitted by:	<rs.os@t-online.de>

Changes:
  head/net/wpa_gui/Makefile
  head/net/wpa_gui/files/patch-os_unix.c
  head/net/wpa_gui/files/patch-src_common_wpa__ctrl.c
  head/net/wpa_gui/files/patch-src_utils_os__unix.c
  head/net/wpa_gui/files/patch-wpa__supplicant_wpa__gui-qt4_wpagui.cpp
  head/net/wpa_gui/files/patch-wpa_ctrl.c
  head/net/wpa_gui/files/patch-wpagui.cpp