Bug 213873

Summary: games/pioneer: Update to 20161028
Product: Ports & Packages Reporter: lightside <lightside>
Component: Individual Port(s)Assignee: Guido Falsi <madpilot>
Status: Closed FIXED    
Severity: Affects Only Me CC: madpilot
Priority: --- Keywords: patch
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
Proposed patch (since 422087 revision)
lightside: maintainer-approval+
Proposed patch (since 422087 revision) lightside: maintainer-approval+

Description lightside 2016-10-29 05:50:43 UTC 
Created attachment 176260 [details]
Proposed patch (since 422087 revision)

Patch to update games/pioneer port from 20160610 to 20161028 version.

Look following link for changes:
https://github.com/pioneerspacesim/pioneer/compare/20160610...20161028

- Add BUILD_VERSION variable, which allows to use GH_TAGNAME for git commit
- Move QUICKSTART_PATH variable to DOCS_SUB_LIST option
- Add NOGPUJOBS option
- Remove bsd.port.options.mk include
- Clarify sed patch for libprofiler.a
- Add new file to sed patch for FreeBSD 9.3
Comment 1 Guido Falsi freebsd_committer freebsd_triage 2016-10-31 17:49:03 UTC 
(In reply to lightside from comment #0)
> Created attachment 176260 [details]
> Proposed patch (since 422087 revision)
> 
> Patch to update games/pioneer port from 20160610 to 20161028 version.
> 
> Look following link for changes:
> https://github.com/pioneerspacesim/pioneer/compare/20160610...20161028
> 
> - Add BUILD_VERSION variable, which allows to use GH_TAGNAME for git commit

I'm not getting the reason of this patch.

At present BUILD_VERSION and GH_TAGNAME would be the same. Without this change you're using GH_TAGNAME in PORTVERSION, which is not a problem.

If naming schema of the port changges, you'll anyway have to change PORTVERSION, and most probably have fixed PORTVERSION and GH_TAGNAME depending on PORTVERSION (which is the default).

So I'm not getting what you are gaining by adding a variable which will be the same as GH_TAGNAME anyway.
Comment 2 lightside 2016-10-31 20:21:47 UTC 
Created attachment 176350 [details]
Proposed patch (since 422087 revision)

(In reply to comment #1)
> So I'm not getting what you are gaining by adding a variable which will be the
> same as GH_TAGNAME anyway.
I used this variant for git bisection (related to NOGPUJOBS port's option).

(In reply to comment #0)
> - Add BUILD_VERSION variable, which allows to use GH_TAGNAME for git commit
Ok, I removed this.
Comment 3 commit-hook freebsd_committer freebsd_triage 2016-11-02 10:24:59 UTC 
A commit references this bug:

Author: madpilot
Date: Wed Nov  2 10:24:08 UTC 2016
New revision: 425132
URL: https://svnweb.freebsd.org/changeset/ports/425132

Log:
  - Update pioneer to 20161028
  - Add NOGPUJOBS option

  PR:		213873
  Submitted by:	lightside <lightside@gmx.com>

Changes:
  head/games/pioneer/Makefile
  head/games/pioneer/distinfo
Comment 4 Guido Falsi freebsd_committer freebsd_triage 2016-11-02 10:25:57 UTC 
Committed. Thanks!