Bug 213879
| Summary: | devel/py-tox: Remove argparse RUN_DEPENDS (scheduled for removal) | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Li-Wen Hsu <lwhsu> | ||||
| Component: | Individual Port(s) | Assignee: | Li-Wen Hsu <lwhsu> | ||||
| Status: | Closed FIXED | ||||||
| Severity: | Affects Only Me | CC: | koobs | ||||
| Priority: | --- | Keywords: | patch | ||||
| Version: | Latest | Flags: | koobs:
maintainer-feedback+
|
||||
| Hardware: | Any | ||||||
| OS: | Any | ||||||
| Attachments: |
|
||||||
I understand the motiviation for this change, but I strongly prefer to keep ports I maintain as declarative (and explicit) reflections of their respective upstream packages. Per comment 1 (declarative and explicit), this would includes versions set in USES=python:<version-spec> to match as closely as possible, the upstream version compatibility. (In reply to Kubilay Kocak from comment #2) but, I'm going to remove devel/py-argparse, will it be a problem if we still have these lines after removal? (In reply to Li-Wen Hsu from comment #3) Yes unfortunately, since most RUN_DEPENDS these days refer to package names and not files (PYTHON_SITELIBDIR/foo/bar.py), which by itself is not a bad thing. Otherwise, it would only be an issue for users after argparse removal *and* who have a python port installed that is not in the base ports tree, since ports would not 'find' the file that was needed, and the build would stop. The user could then pip install argparse, and then the port could be built. Having said that (for reference), I agree that in the absence of a global/standard method to allow for builds to work after a port is removed such as mentioned above, the reference should be removed. I shed a tear today for declarative python ports. Over to you Li-Wen A commit references this bug: Author: lwhsu Date: Sat Oct 29 17:37:24 UTC 2016 New revision: 424923 URL: https://svnweb.freebsd.org/changeset/ports/424923 Log: - Remove depending on argparse, all Python versions in ports tree have it as built-in PR: 213879 Submitted by: lwhsu Approved by: koobs (maintainer) Changes: head/devel/py-tox/Makefile |
Created attachment 176271 [details] py-tox.patch - Remove depending on argparse, all Python versions in ports tree have it as built-in