Bug 213949

Summary: [patch] x11-wm/bspwm: update to 0.9.2 and take maintainership
Product: Ports & Packages Reporter: Oleh Hushchenkov <o.hushchenkov>
Component: Individual Port(s)Assignee: Jan Beich <jbeich>
Status: Closed FIXED    
Severity: Affects Some People CC: o.hushchenkov
Priority: --- Keywords: patch
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
up to 0.9.2
none
up to 0.9.2 fixed none

Description Oleh Hushchenkov 2016-10-31 12:47:27 UTC
Created attachment 176340 [details]
up to 0.9.2

Update port x11-wm/bspwm and take maintainership.
Comment 1 Jan Beich freebsd_committer freebsd_triage 2016-11-01 20:53:57 UTC
Comment on attachment 176340 [details]
up to 0.9.2

poudriere build fails:

  cc -O2 -pipe  -fstack-protector -fno-strict-aliasing -std=c99 -pedantic -Wall -Wextra  -I/usr/local/include   -DVERSION=\"0.9.2\"  -c -o pointer.o pointer.c
  pointer.c:25:10: fatal error: 'xcb/xcb_keysyms.h' file not found
  #include <xcb/xcb_keysyms.h>
	   ^
  1 error generated.
Comment 2 Jan Beich freebsd_committer freebsd_triage 2016-11-01 21:06:38 UTC
Comment on attachment 176340 [details]
up to 0.9.2

>@@ -1,11 +1,11 @@
>-# Created by: Anton Törnqvist <antont@inbox.lv>
>+# Created by: Anton T?rnqvist <antont@inbox.lv>

The letter is encoded with ISO-8859-1. Changing to UTF-8 without approval maybe fine but mangling is not. Note, there's a version without diaeresis in the tree:

  devel/libtermkey/Makefile:# Created by: Anton Tornqvist <antont@inbox.lv>
  devel/unibilium/Makefile:# Created by: Anton Tornqvist <antont@inbox.lv>
  editors/neovim/Makefile:# Created by: Anton Tornqvist <antont@inbox.lv>
  x11/antimicro/Makefile:# Created by: Anton Toernqvist <antont@inbox.lv>
Comment 3 Oleh Hushchenkov 2016-11-02 05:57:54 UTC
Created attachment 176406 [details]
up to 0.9.2 fixed
Comment 4 Oleh Hushchenkov 2016-11-02 06:07:11 UTC
Add forgotten dependency to xcb-util-keysyms.
Fix creators name as in other ports.
Update patch to reflect changes.
Comment 5 commit-hook freebsd_committer freebsd_triage 2016-11-02 10:03:55 UTC
A commit references this bug:

Author: jbeich
Date: Wed Nov  2 10:03:34 UTC 2016
New revision: 425130
URL: https://svnweb.freebsd.org/changeset/ports/425130

Log:
  x11-wm/bspwm: update to 0.9.2

  - Pass maintainership to the submitter

  Changes:	https://github.com/baskerville/bspwm/compare/0.9.1...0.9.2
  PR:		213949
  Submitted by:	Oleg Gushchenkov <gor@clogic.com.ua>

Changes:
  head/x11-wm/bspwm/Makefile
  head/x11-wm/bspwm/distinfo
  head/x11-wm/bspwm/files/patch-Makefile
  head/x11-wm/bspwm/pkg-plist
Comment 6 Oleh Hushchenkov 2016-11-02 10:06:32 UTC
Thanks!

Can you look on https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=213946 ?
Comment 7 Jan Beich freebsd_committer freebsd_triage 2016-11-02 10:12:24 UTC
I've landed your patch without ö -> o (lossy) conversion. It'd set a bad precedent if we change "Created by" without approval.