Bug 214167

Summary: lang/spidermonkey24 24.2.0_2: Not supported ARM architecture
Product: Ports & Packages Reporter: Ulrich Grey <usenet>
Component: Individual Port(s)Assignee: Koop Mast <kwm>
Status: Closed FIXED    
Severity: Affects Some People CC: mikael
Priority: ---    
Version: Latest   
Hardware: arm   
OS: Any   
Attachments:
Description Flags
spidermonkey24-24.2.0_2 poudriere build log
none
armv6 fix
none
armv6 fix none

Description Ulrich Grey 2016-11-03 15:28:31 UTC
Created attachment 176592 [details]
spidermonkey24-24.2.0_2 poudriere build log

I have tried a native build running:
FreeBSD 11.0-STABLE #0 r307979M arm armv6

(00:16:19) In file included from /wrkdirs/usr/ports/lang/spidermonkey24/work/mozjs-24.2.0/js/src/vm/ArgumentsObject.cpp:7:
(00:16:19) In file included from ./vm/ArgumentsObject-inl.h:12:
(00:16:19) In file included from ./vm/ScopeObject.h:12:
(00:16:19) In file included from ./jsweakmap.h:12:
(00:16:19) In file included from ./jscompartment.h:16:
(00:16:19) In file included from ./gc/Zone.hIn file included from :/wrkdirs/usr/ports/lang/spidermonkey24/work/mozjs-24.2.0/js/src/frontend/BytecodeCompiler.cpp22::
(00:16:19) 10In file included from :
(00:16:19) ./vm/GlobalObject.hIn file included from :./frontend/BytecodeEmitter.h18::
(00:16:19) 19In file included from :
(00:16:19) ./builtin/RegExp.hIn file included from :./frontend/SharedContext.h13::
(00:16:19) 21In file included from :
(00:16:19) ./vm/RegExpObject.hIn file included from :./vm/ScopeObject.h21::
(00:16:19) 12In file included from :
(00:16:19) ./yarr/MatchResult.hIn file included from :./jsweakmap.h31::
(00:16:19) 12In file included from :
(00:16:19) ./yarr/wtfbridge.hIn file included from :./jscompartment.h20::
(00:16:19) 16./assembler/wtf/Platform.h:
(00:16:19) :In file included from 350./gc/Zone.h::622::
(00:16:19)  In file included from error./vm/GlobalObject.h: :"Not supported ARM architecture"18
...
Comment 1 Mikael Urankar freebsd_committer freebsd_triage 2016-12-23 15:33:18 UTC
Created attachment 178228 [details]
armv6 fix

Can you try the attached patch please?
Comment 2 Mikael Urankar freebsd_committer freebsd_triage 2016-12-23 16:45:48 UTC
Created attachment 178233 [details]
armv6 fix

Try this patch instead of the previous one.

build log:
http://mikael.urankar.free.fr/FreeBSD/arm/build_logs/spidermonkey24-24.2.0_2.log
Comment 3 Mikael Urankar freebsd_committer freebsd_triage 2017-06-03 11:37:10 UTC
ping, the attached patch fixes the issue

build log:
http://mikael.urankar.free.fr/FreeBSD/arm/build_logs/spidermonkey24-24.2.0_5.log
Comment 4 commit-hook freebsd_committer freebsd_triage 2017-06-03 19:28:40 UTC
A commit references this bug:

Author: kwm
Date: Sat Jun  3 19:27:36 UTC 2017
New revision: 442517
URL: https://svnweb.freebsd.org/changeset/ports/442517

Log:
  Fix the build on armv6

  PR:		214167
  Submitted by:	mikael.urankar@gmail.com
  Reported by:	Ulrich Grey <usenet@ulrich-grey.de>

Changes:
_U  head/lang/spidermonkey24/files/patch-assembler_jit_ExecutableAllocator.h
  head/lang/spidermonkey24/files/patch-assembler_wtf_Platform.h
  head/lang/spidermonkey24/files/patch-vm_NumericConversions.h