Bug 214409
| Summary: | Compile failure in libexec/ftpd/ftpd.c due to undefined macros when blacklist support is disabled | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Base System | Reporter: | Matthew Rezny <rezny> | ||||
| Component: | bin | Assignee: | Kurt Lidl <lidl> | ||||
| Status: | Closed FIXED | ||||||
| Severity: | Affects Some People | CC: | lidl | ||||
| Priority: | --- | Keywords: | patch | ||||
| Version: | 11.0-STABLE | ||||||
| Hardware: | Any | ||||||
| OS: | Any | ||||||
| Attachments: |
|
||||||
A commit references this bug: Author: lidl Date: Sat Nov 12 03:07:41 UTC 2016 New revision: 308567 URL: https://svnweb.freebsd.org/changeset/base/308567 Log: Fix build when WITHOUT_BLACKLIST=yes is specified PR: 214409 Submitted by: matthew Reported by: matteo MFC after: 3 days Sponsored by: The FreeBSD Foundation Changes: head/libexec/ftpd/ftpd.c Patch has been merged into stable/11 with commit r308703. |
Created attachment 176872 [details] unconditionally include header to prevent compile failure caused by undefined macros The recent blacklist change to ftpd in r308175/r308446 consolidated most occurrences of #ifdef USE_BLACKLIST by replacing the blacklist function calls with macros. However, those macros are defined in a header whose inclusion is still wrapped in a #ifdef USE_BLACKLIST. Thus, when blacklist support is disabled the macros are undefined and compilation of ftpd.c fails. The blacklist_client.h header should be included unconditionally.