Bug 214468
| Summary: | sysutils/lxterminal return error in gmesssage.h | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Walter Schwarzenfeld <w.schwarzenfeld> | ||||||||||
| Component: | Individual Port(s) | Assignee: | Olivier Duchateau <olivierd> | ||||||||||
| Status: | Closed FIXED | ||||||||||||
| Severity: | Affects Only Me | CC: | gnome, lantw44, olivierd, ports-bugs | ||||||||||
| Priority: | --- | ||||||||||||
| Version: | Latest | ||||||||||||
| Hardware: | Any | ||||||||||||
| OS: | Any | ||||||||||||
| Attachments: |
|
||||||||||||
Forgot:_ FreeBSD 10.3-RELEASE-p9 amd64. Please move this bug to sysutils/lxterminal. This is not a bug of glib. It is a very common bug because old versions of gcc didn't report this kind of warning by default and old versions of glib headers had a pragma to suppress the gcc warning. g_return_if_fail must not be used in a function that has a return value. g_return_val_if_fail should be used instead. This is already fixed by upstream: https://git.lxde.org/gitweb/?p=lxde/lxterminal.git;a=commitdiff;h=4cc47aa Created attachment 177146 [details]
svn_diff-sysutils_lxterminal
Thanks! --- I test it with poudriere tomorrow, now I have no time. Tests with poudrier 10.3amd64 and i386 ok. Poudriere tests on 93amd64 and i386 also ok. Instead of commenting out 'USE_GCC= yes', you should simply delete the line. I took the upstream patch, and changed nothing, but I will delete the line, you are right. Created attachment 177169 [details]
patch-src_settings.c
Sorry, was a misunderstood, had nothing to do with the patch, only with the Makefile. Created attachment 177170 [details]
patch-src_settings.c
I attached the wrong file before. Attachment 177170 [details] has duplicate diffs for both Makefile and files/.
Created attachment 177172 [details]
patch-src_settings.c
sorry, should now correct.
Yes, it looks correct now. A commit references this bug: Author: olivierd Date: Sun Nov 20 10:54:07 UTC 2016 New revision: 426568 URL: https://svnweb.freebsd.org/changeset/ports/426568 Log: - Fix build with clang - Bump PORTREVISION PR: 214468 Submitted by: <w.schwarzenfeld@utanet.at> Reviewed by: Ting-Wei Lan Obtained from: Upstream repository Changes: head/sysutils/lxterminal/Makefile head/sysutils/lxterminal/files/ head/sysutils/lxterminal/files/patch-src_setting.c Committed, thanks! |
I tried to reinstall lxterminal. It failed with: setting.c:165:5: error: non-void function 'copy_setting' should return a value [-Wreturn-type] g_return_if_fail (setting != NULL); ^ /usr/local/include/glib-2.0/glib/gmessages.h:373:3: note: expanded from macro 'g_return_if_fail' return; \ ^ 1 error generated. the error is in /usr/local/include/glib-2.0/glib/gmessages.h: line 374 #define g_return_if_fail(expr) G_STMT_START{ \ if G_LIKELY(expr) { } else \ { \ g_return_if_fail_warning (G_LOG_DOMAIN, \ G_STRFUNC, \ #expr); \ => return; \ }; and the same in lin 392. If I set return 1 I got a lot more errors. So I deleted it. But this is surely wrong. g_return_if_fails must return something.