Bug 214578

Summary: sysutils/bareos-client: build failure (patching AND linker failure)
Product: Ports & Packages Reporter: O. Hartmann <ohartmann>
Component: Individual Port(s)Assignee: Jose Alonso Cardenas Marquez <acm>
Status: Closed FIXED    
Severity: Affects Many People Flags: bugzilla: maintainer-feedback? (acm)
Priority: ---    
Version: Latest   
Hardware: Any   
OS: Any   
Bug Depends on:    
Bug Blocks: 212282    

Description O. Hartmann 2016-11-16 18:33:30 UTC 
The recent update of the backup port suite 

sysutils/bareos-client 
sysutils/bareos-server 
www/bareos-webui

from version 15.2.2 to 16.2.4 fails due to the error shown below:

=> SHA256 Checksum OK for bareos-bareos-Release-16.2.4_GH0.tar.gz.
===>  Patching for bareos-client-16.2.4
===>  Applying FreeBSD patches for bareos-client-16.2.4
1 out of 1 hunks failed--saving rejects to src/stored/Makefile.in.rej
=> Patch patch-src-stored-Makefile.in failed to apply cleanly.
=> Patch(es) patch-autoconf_Make.common.in patch-configure patch-src-console-Makefile.in patch-src-dird-Makefile.in patch-src-filed-Makefile.in patch-src-plugins-filed_Makefile.in patch-src-plugins-stored-Makefile.in patch-src-qt-console-bat.pro.in applied cleanly.
*** Error code 1

It seems, from my perspective, that

files/patch-src-stored-Makefile.in

is obsolete, since it is from July 2015 (beware of the hyphen "-" instead of the underscore "_" between stored-Makefile of the wrong version - the correct one seems to have the underscore).

Simply deleting this file in question: files/patch-src-stored-Makefile.in

and going further on with the compilation process ends up in a linker error:

[...]
ua_update.c:(.text+0x148f): undefined reference to `db_get_storage_record(JCR*, B_DB*, STORAGE_DBR*)'
/usr/local/lib/libbareoscfg.so: undefined reference to `dump_resource(int, RES*, void (*)(void*, char const*, ...), void*, bool)'
c++: error: linker command failed with exit code 1 (use -v to see invocation)
*** [bareos-dir] Error code 1
Comment 1 commit-hook freebsd_committer freebsd_triage 2016-11-16 19:42:10 UTC 
A commit references this bug:

Author: acm
Date: Wed Nov 16 19:41:40 UTC 2016
New revision: 426262
URL: https://svnweb.freebsd.org/changeset/ports/426262

Log:
  - Remove duplicate patch file patch-src-stored_Makefile.in
  - Fix build

  PR:	214578
  Reported by:	ohartmann at walstatt.org

Changes:
  head/sysutils/bareos-server/files/patch-src-stored-Makefile.in
  head/sysutils/bareos-server/files/patch-src-stored_Makefile.in