|Summary:||textproc/py-sphinx: plist is incomplete|
|Product:||Ports & Packages||Reporter:||Raphael Kubo da Costa <rakuco>|
|Component:||Package Infrastructure||Assignee:||Kris Moore <kmoore>|
|Severity:||Affects Only Me||CC:||kmoore, python|
Description Raphael Kubo da Costa 2016-11-18 19:10:07 UTC
textproc/py-sphinx fails `make check-plist`: ===> Checking for items in pkg-plist which are not in STAGEDIR Error: Missing: %%PYTHON_SITELIBDIR%%/sphinx/pycode/Grammar-py2-sphinx1.4.pickle USE_PYTHON=autoplist does not take into account that that .pickle file that is installed manually in post-install.
Comment 1 commit-hook 2016-11-18 20:47:30 UTC
A commit references this bug: Author: kmoore Date: Fri Nov 18 20:46:43 UTC 2016 New revision: 426339 URL: https://svnweb.freebsd.org/changeset/ports/426339 Log: - Fix issue with pkg-plist and missing pickle PR: 214634 Reported by: rakuco@ Changes: head/textproc/py-sphinx/Makefile
Comment 2 Kris Moore 2016-11-18 20:49:00 UTC
Not sure how I missed that before, seemed to pass the test on my laptop anyway. Thanks for the heads up!
Comment 3 Raphael Kubo da Costa 2016-11-18 21:38:26 UTC
Are you sure this is the right fix? That post-install was added in ports r301002 to avoid some bug. Plus, this commit will change the generated package so PORTREVISION should probably be bumped.
Comment 4 Kris Moore 2016-11-19 02:08:50 UTC
I did test the new port, and it does indeed seem to install a .pickle file and builds our docs just fine. I'm wondering if its automatically building it now, which make the extra post-install step unnecessary (and resulted in the extra plist item) My pkg info -l py27-sphinx shows the following file that indicated it did indeed build without the post-install: /usr/local/lib/python2.7/site-packages/sphinx/pycode/Grammar-py2-sphinx1.4.pickle As for PORTREVISION, I had thought the port was broken / not building packages due to plist error. However if that's not the case I'll be happy to bump it.