Bug 214744

Summary: [exp-run] modernize the dependency code in bsd.qt.mk
Product: Ports & Packages Reporter: Tobias C. Berner <tcberner>
Component: Ports FrameworkAssignee: Tobias C. Berner <tcberner>
Status: Closed FIXED    
Severity: Affects Only Me CC: kde, linimon, portmgr, ports-bugs
Priority: ---    
Version: Latest   
Hardware: Any   
OS: Any   
URL: https://reviews.freebsd.org/D8602
Attachments:
Description Flags
update dependency code
none
add-on patch to bsd.qt.mk none

Description Tobias C. Berner freebsd_committer freebsd_triage 2016-11-22 15:32:00 UTC 
Created attachment 177284 [details]
update dependency code

Hi

kde@  would like to ask for an exp-run to update the dependency generation code in bsd.qt.mk to the one from kde.mk.

The diff is attached, and can also be found here:
http://people.freebsd.org/~tcberner/patches/bsd.qt.mk.dependency_code.v1

mfg Tobias
Comment 1 Mark Linimon freebsd_committer freebsd_triage 2016-11-22 16:33:31 UTC 
Created attachment 177287 [details]
add-on patch to bsd.qt.mk
Comment 2 Antoine Brodin freebsd_committer freebsd_triage 2016-11-24 20:17:23 UTC 
Exp-run looks fine.
Comment 3 commit-hook freebsd_committer freebsd_triage 2016-11-25 11:26:32 UTC 
A commit references this bug:

Author: tcberner
Date: Fri Nov 25 11:26:18 UTC 2016
New revision: 427106
URL: https://svnweb.freebsd.org/changeset/ports/427106

Log:
  Update the dependency code in bsd.qt.mk to the one from kde.mk

  The dependency code from kde.mk can add LIB_DEPENDS if the sense-file is a
  library. Import this into bsd.qt.mk

  PR:		214744
  Reviewed by:	rakuco, mat
  Approved by:	mat (mentor), rakuco (mentor)
  Exp-run by:	antoine
  Differential Revision:	https://reviews.freebsd.org/D8602

Changes:
  head/Mk/bsd.qt.mk
Comment 4 Tobias C. Berner freebsd_committer freebsd_triage 2016-11-25 11:27:00 UTC 
Thanks for the exp-run.

Commited.