Bug 214808
| Summary: | [PATCH] mail/lbdb: update to 0.42 | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Niklaas Baudet von Gersdorff <me> | ||||
| Component: | Individual Port(s) | Assignee: | Raphael Kubo da Costa <rakuco> | ||||
| Status: | Closed FIXED | ||||||
| Severity: | Affects Only Me | CC: | alexey, rakuco | ||||
| Priority: | --- | Keywords: | patch | ||||
| Version: | Latest | Flags: | rakuco:
maintainer-feedback-
|
||||
| Hardware: | Any | ||||||
| OS: | Any | ||||||
| Attachments: |
|
||||||
Maintainer timeout. (In reply to Niklaas Baudet von Gersdorff from comment #0) > WARN: Makefile: GETENT appears in PORT_OPTIONS:M, but is not listed in > OPTIONS_DEFINE. It looks like this got broken years ago in ports r319851, it's never been an actual option. I've fixed the GETENT part in ports r429501. A commit references this bug: Author: rakuco Date: Mon Dec 26 12:36:25 UTC 2016 New revision: 429505 URL: https://svnweb.freebsd.org/changeset/ports/429505 Log: Update to 0.42. Also set LICENSE and strip the installed binaries. PR: 214808 Submitted by: Niklaas Baudet von Gersdorff <stdin@niklaas.eu> Approved by: maintainer timeout (alexey@renatasystems.org, 32 days) Changes: head/mail/lbdb/Makefile head/mail/lbdb/distinfo head/mail/lbdb/pkg-plist Committed, thank you for your patch. Compared to the version you submitted, I've also set LICENCE_FILE and changed LICENSE to GPLv2+, as the headers in each of the scripts say "gplv2 or later". Thanks a lot for taking care of this and extra patching! |
Created attachment 177354 [details] Update to version 0.42 First time submitting an update+patch, so please bear with me. Portlint gives some errors, but these I also got with the older version. For the patched version they are: WARN: Makefile: GETENT appears in PORT_OPTIONS:M, but is not listed in OPTIONS_DEFINE. WARN: /usr/home/niklaas/ports-devel/lbdb/files/patch-mutt_ldap_query: patch was not generated using ``make makepatch''. It is recommended to use ``make makepatch'' when you need to [re-]generate a patch to ensure proper patch format. 0 fatal errors and 2 warnings found. I don't know what GETENT does and what is it for in this particular case. And I refrained from recreating a patch because the current one seems to work. Probably the maintainer knows more. I'm happy to assist if I can help. As you can see in the diff, I added LICENSE and some ${STRIP_CMD}, next to updating PORTVERSION, removing PORTREVISION, updating distinfo, and removing libexec/lbdb/munge-keeporder from pkg-plist.