Bug 214839

Summary: databases/pgmodeler: doesn't build for 9 and 10
Product: Ports & Packages Reporter: Loïc Bartoletti <lbartoletti>
Component: Individual Port(s)Assignee: Dmitry Marakasov <amdmi3>
Status: Closed FIXED    
Severity: Affects Some People CC: koobs, lbartoletti
Priority: --- Keywords: easy, needs-qa, patch
Version: LatestFlags: koobs: maintainer-feedback? (lbartoletti)
lbartoletti: merge-quarterly?
Hardware: Any   
OS: Any   
Attachments:
Description Flags
pgmodeler v0.8.2_1 fix build lbartoletti: maintainer-approval+

Description Loïc Bartoletti freebsd_committer freebsd_triage 2016-11-26 07:39:51 UTC
Created attachment 177404 [details]
pgmodeler v0.8.2_1 fix build

Add compiler options for 9 (USE GCC) and 10 (USE clang >= 3.6)
Comment 1 Loïc Bartoletti freebsd_committer freebsd_triage 2016-11-26 07:44:24 UTC
poudriere 9, 10, 11 i386/amd64 ok
portlint ok
Comment 2 Kubilay Kocak freebsd_committer freebsd_triage 2016-11-26 07:56:30 UTC
Is it possible (or was it tried) to fix the build on 9/10 using USES=compiler:[args] ? 

Having the framework determine the correct compiler is preferable to hard-coded logic on a per-port basis.

If USES=compiler can't currently make a distinction on some functional basis and an automatic compiler selection that allows this port to build, perhaps it could be taught to do so.

What are the compiler/language features this port requires that aren't available on 9 & 10?

Can you please attach the failing build logs for 9 & 10 as well please
Comment 3 Loïc Bartoletti freebsd_committer freebsd_triage 2016-11-27 07:10:23 UTC
Hi, 

You can fix with using USES=c++14-lang but I thought it was not clean. This port doesn't require C++14 but a most recent compiler.

http://portsmon.freebsd.org/portoverview.py?category=databases&portname=pgmodeler
Comment 4 Dmitry Marakasov freebsd_committer freebsd_triage 2016-12-28 12:49:21 UTC
This does not build on 10.1. I'll try clang38 instead.
Comment 5 Dmitry Marakasov freebsd_committer freebsd_triage 2016-12-28 18:14:37 UTC
It doesn't help as it's likely libc++ problem. Anyway, we have just 3 days for 10.[12] and 9.x to live, so it'll fix itself as soon as these are EOLed.
Comment 6 Dmitry Marakasov freebsd_committer freebsd_triage 2016-12-29 09:09:22 UTC
Although USE_GCC fixes it on 10.1. It builds fine on other versions.
Comment 7 commit-hook freebsd_committer freebsd_triage 2016-12-29 09:09:41 UTC
A commit references this bug:

Author: amdmi3
Date: Thu Dec 29 09:09:23 UTC 2016
New revision: 429881
URL: https://svnweb.freebsd.org/changeset/ports/429881

Log:
  - Unbreak on 10.1 by using gcc

  PR:		214839
  Submitted by:	lbartoletti@tuxfamily.org (maintainer)

Changes:
  head/databases/pgmodeler/Makefile