Summary: | multimedia/ffmpeg: fix RTP stream | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | Ports & Packages | Reporter: | Kevin Lo <kevlo> | ||||||
Component: | Individual Port(s) | Assignee: | freebsd-multimedia (Nobody) <multimedia> | ||||||
Status: | Closed FIXED | ||||||||
Severity: | Affects Some People | Flags: | bugzilla:
maintainer-feedback?
(multimedia) jbeich: merge-quarterly? |
||||||
Priority: | --- | ||||||||
Version: | Latest | ||||||||
Hardware: | Any | ||||||||
OS: | Any | ||||||||
Attachments: |
|
Description
Kevin Lo
![]() ![]() Comment on attachment 177416 [details] Fix rtp stream Looks OK except one nit: > +- getnameinfo((struct sockaddr*) &addr, sizeof(addr), > ++ getnameinfo((struct sockaddr*) &addr, > ++#ifdef __FreeBSD__ > ++ ((struct sockaddr*) &addr)->sa_len, sa_len exists on BSDs, OS X, Solaris but in ports/ only FreeBSD and DragonFly are important. Please, convert to #if HAVE_STRUCT_SOCKADDR_SA_LEN similar to libavformat/network.h. Also add "MFH: 2016Q4" to commit message when landing. Created attachment 177418 [details]
Fix rtp stream
The revised patch convert to #if HAVE_STRUCT_SOCKADDR_SA_LEN as jbiech@ suggested.
(In reply to Jan Beich (mail not working) from comment #1) Ok, I updated the patch as you suggested, thanks. A commit references this bug: Author: kevlo Date: Sun Nov 27 13:41:01 UTC 2016 New revision: 427233 URL: https://svnweb.freebsd.org/changeset/ports/427233 Log: Fix RTP stream; FreeBSD's socket calls require the sockaddr struct length to agree with the address family. PR: 214852 Submitted by: me Approved by: jbeich MFH: 2016Q4 Changes: head/multimedia/ffmpeg/Makefile head/multimedia/ffmpeg/files/patch-libavformat_rtsp.c Committed in r427233. A commit references this bug: Author: kevlo Date: Tue Nov 29 13:50:12 UTC 2016 New revision: 427379 URL: https://svnweb.freebsd.org/changeset/ports/427379 Log: MFH: r427233 Fix RTP stream; FreeBSD's socket calls require the sockaddr struct length to agree with the address family. PR: 214852 Submitted by: me Approved by: jbeich Approved by: ports-secteam (junovitch) Changes: _U branches/2016Q4/ branches/2016Q4/multimedia/ffmpeg/Makefile branches/2016Q4/multimedia/ffmpeg/files/patch-libavformat_rtsp.c |