Bug 214924

Summary:	www/chromium: no sound. Set ALSA to ON by default
Product:	Ports & Packages	Reporter:	Pavel Timofeev <timp87>
Component:	Individual Port(s)	Assignee:	Emanuel Haupt <ehaupt>
Status:	Closed FIXED
Severity:	Affects Many People	CC:	chromium, clutton, koobs
Priority:	---	Keywords:	easy, feature
Version:	Latest	Flags:	koobs: maintainer-feedback+ koobs: merge-quarterly+
Hardware:	Any
OS:	Any

Description Pavel Timofeev 2016-11-29 08:50:39 UTC

ALSA option was split in www/chromium port during this commit https://svnweb.freebsd.org/ports?view=revision&revision=426855
Also it set ALSA to off by default which led to non-working audio in official package. Prevoiusly it was enabled without an options.

Please, set it to on by default.

Please, MFH it also to 2016Q4!

Comment 1 clutton 2016-11-29 19:10:59 UTC

https://github.com/gliaskos/freebsd-chromium/blob/master/www/chromium/Makefile#L114

It's fixed, but probably not commited.

Comment 2 commit-hook freebsd_committer

2016-11-30 09:33:33 UTC

A commit references this bug:

Author: ehaupt
Date: Wed Nov 30 09:32:29 UTC 2016
New revision: 427414
URL: https://svnweb.freebsd.org/changeset/ports/427414

Log:
  ALSA option was split during r426855. Also it set ALSA to off by default which
  led to non-working audio. Turn back on by default.

  Development repositories have some code to choose between ALSA and PulseAudio.
  This will be merged with the next version update.

  PR:		214924
  Submitted by:	timp87@gmail.com
  Approved by:	chromium (rene)
  MFH:		2016Q4

Changes:
  head/www/chromium/Makefile

Comment 3 commit-hook freebsd_committer

2016-12-01 07:58:37 UTC

A commit references this bug:

Author: ehaupt
Date: Thu Dec  1 07:58:19 UTC 2016
New revision: 427474
URL: https://svnweb.freebsd.org/changeset/ports/427474

Log:
  MFH: r427414

  ALSA option was split during r426855. Also it set ALSA to off by default which
  led to non-working audio. Turn back on by default.

  Development repositories have some code to choose between ALSA and PulseAudio.
  This will be merged with the next version update.

  PR:		214924
  Submitted by:	timp87@gmail.com
  Approved by:	ports-secteam (junovitch), chromium (rene)

Changes:
_U  branches/2016Q4/
  branches/2016Q4/www/chromium/Makefile

Comment 4 Kubilay Kocak freebsd_committer

2016-12-03 02:48:27 UTC

Committed and merged, thank you for the report Tim.

Assign to committer that resolved and set flags correctly.