Bug 215026
| Summary: | irc/quassel: PostregSQL option + restructure options | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Christian Schwarz <me> | ||||
| Component: | Individual Port(s) | Assignee: | Ben Woods <woodsb02> | ||||
| Status: | Closed FIXED | ||||||
| Severity: | Affects Only Me | Keywords: | patch | ||||
| Priority: | --- | Flags: | bugzilla:
maintainer-feedback?
(woodsb02) |
||||
| Version: | Latest | ||||||
| Hardware: | Any | ||||||
| OS: | Any | ||||||
| Attachments: |
|
||||||
Any progress / comments on this one? Is the change so big it should go into Phabricator? Apologies, I had missed this bug report. In general it looks sensible. I'll have a look at it this weekend. Cheers, Ben Also - no phabricator required. Committed, with a few changes. Thanks for the submission! A commit references this bug: Author: woodsb02 Date: Sat Dec 24 03:48:31 UTC 2016 New revision: 429306 URL: https://svnweb.freebsd.org/changeset/ports/429306 Log: irc/quassel and irc/quassel-core: Add PostgreSQL option - Qt decides at run-time which SQL drivers are installed and only then allows running Quassel with those database backends. - Also reformat to minimise diff of irc/quassel-core (slave) from irc/quassel (master) as much as possible (per recommendation in the Porter's handbook). PR: 215026 Submitted by: Christian Schwarz <me@cschwarz.com> Approved by: adamw (mentor, implicit) Changes: head/irc/quassel/Makefile head/irc/quassel-core/Makefile |
Created attachment 177634 [details] The patch with the changes described in the bug report. irc/quassel: PostregSQL option + restructure options PostgreSQL support: Qt decides at run-time whether the PostgreSQL driver is installed and only then allows running Quassel with that database backend. The fix without this patch is to manually install databases/qt5-sqldrivers-pgsql Users might run into this issue when migrating from Sqlite3 to PostgreSQL. Restructuring of master/slave port: Only fairly recently has irc/quassel been split up into irc/quassel and irc/quassel-core. Adding the explicit backend-knobs (see above) would have required adding them only to the irc/quassel-core port. The handbook states that the slave should really only override config knobs and otherwise differ as little as possible from master. Hence, despite of the addition of several '.if ${PORT_OPTIONS:}', this change unifies all options in the master port. Side effect, which may require a note in UPDATING: the MODULE option had to be made a RADIO. -> some users might need to reconfig