Summary: | lang/erlang: enable dtrace by default where possible | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | Ports & Packages | Reporter: | Steve Wills <swills> | ||||||
Component: | Individual Port(s) | Assignee: | Jimmy Olgeni <olgeni> | ||||||
Status: | Closed FIXED | ||||||||
Severity: | Affects Only Me | CC: | dch | ||||||
Priority: | --- | Flags: | bugzilla:
maintainer-feedback?
(olgeni) |
||||||
Version: | Latest | ||||||||
Hardware: | Any | ||||||||
OS: | Any | ||||||||
Attachments: |
|
(In reply to Steve Wills from comment #0) Merging into the 19.2 upgrade... Quick question - are you able to see the dtrace probes after building an Erlang package in a jail? I can build and see "[dtrace]" in the startup banner, but I see no probes (even if a kernel is installed) (In reply to Jimmy Olgeni from comment #2) Never mind - seems to work when running outside the jail. A commit references this bug: Author: olgeni Date: Fri Dec 23 14:01:12 UTC 2016 New revision: 429262 URL: https://svnweb.freebsd.org/changeset/ports/429262 Log: Update Erlang 19 ports to 19.2. - Copy BROKEN_* settings from lang/erlang to lang/erlang-runtime19 - Enable DTRACE by default where possible (PR 215032) PR: 215032 Submitted by: swills Changes: head/lang/erlang/Makefile head/lang/erlang/distinfo head/lang/erlang-java/Makefile head/lang/erlang-java/distinfo head/lang/erlang-runtime19/Makefile head/lang/erlang-runtime19/distinfo head/lang/erlang-wx/Makefile head/lang/erlang-wx/distinfo head/lang/erlang-wx/pkg-plist Committed - thanks! This breaks erlang on the official package builders A commit references this bug: Author: olgeni Date: Sat Dec 24 07:39:38 UTC 2016 New revision: 429310 URL: https://svnweb.freebsd.org/changeset/ports/429310 Log: Unbreak Erlang 19.2 on the package builder, which has no dtrace support loaded (revert 215032). PR: 215032 Changes: head/lang/erlang/Makefile head/lang/erlang-runtime19/Makefile Created attachment 178245 [details]
erlang patch
It seems that dtraceall in the kernel is not needed to build erlang with dtrace.
A commit references this bug: Author: olgeni Date: Mon Jan 2 13:24:46 UTC 2017 New revision: 430355 URL: https://svnweb.freebsd.org/changeset/ports/430355 Log: In Erlang 19 ports: - Enable DTRACE by default where possible. - Remove unnecessary check for dtraceall module. PR: 215032 Submitted by: antoine Changes: head/lang/erlang/Makefile head/lang/erlang-runtime19/Makefile Looks ok with poudriere builds - dtrace shows up correctly when installing from packages. Anything left to do on this? (In reply to Steve Wills from comment #11) Looks fine so far - I'm closing this. |
Created attachment 177644 [details] erlang dtrace patch See attached patch to enable DTRACE option in erlang by default where possible.