Bug 215065
| Summary: | www/webgrind: update to 1.4 | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Franco Fichtner <franco> | ||||||||
| Component: | Individual Port(s) | Assignee: | Li-Wen Hsu <lwhsu> | ||||||||
| Status: | Closed FIXED | ||||||||||
| Severity: | Affects Only Me | Flags: | lwhsu:
maintainer-feedback+
|
||||||||
| Priority: | --- | ||||||||||
| Version: | Latest | ||||||||||
| Hardware: | Any | ||||||||||
| OS: | Any | ||||||||||
| Attachments: |
|
||||||||||
(In reply to Franco Fichtner from comment #0) Thanks very much for the patch! Do you want to be the maintainer of this port? Sure, I will put this on my watchlist. Cheers, Franco (In reply to Franco Fichtner from comment #2) Great, I am a bit busy for now and not able to work on this right now, please help to check following items: - Build preprocessor in bin/ and install to %%WWWDIR%%/bin (You might want to make it respect CFLAGS, please refer to https://www.freebsd.org/doc/en/books/porters-handbook/dads-cflags.html ) - Remove files in WORKDIR that unnecessary to be in %%WWWDIR%% before COPYTREE_SHARE ( %%WWWDIR%%/bin/preprocessor might be treated separately, which needs ${INSTALL_PROGRAM} ) - Check pkg-plist, I found at least %%WWWDIR%%/favicon.ico is missing - Test with portlint & poudriere - Change the MAINTAINER field to your email address :) Created attachment 177726 [details]
revised patch
Like this? :)
There's one portlint warning about plain python, but I guess this one is normal.
Added preprocessor binary with CXXFLAGS support.
Plist fixed + maintainer updated.
NO_BUILD / NO_ARCH needed to be removed and makefile fixed.
No more errors for "check-orphans" and DEVELOPER=yes, pacakges fine.
Cheers,
Franco
Created attachment 177727 [details]
third revision
forgot to add new patch in files/ in previous
A commit references this bug: Author: lwhsu Date: Wed Dec 7 05:37:19 UTC 2016 New revision: 428033 URL: https://svnweb.freebsd.org/changeset/ports/428033 Log: - Update to 1.4 - Pass maintainership to submitter PR: 215065 Submitted by: Franco Fichtner <franco@opnsense.org> Changes: head/www/webgrind/Makefile head/www/webgrind/distinfo head/www/webgrind/files/ head/www/webgrind/files/patch-makefile head/www/webgrind/pkg-plist |
Created attachment 177680 [details] patch against head Update webgrind to official version 1.4 and fix the path to dot binary for the CALLGRAPH option. Builds fine on poudriere/amd64/10.3.