Bug 215133
| Summary: | www/kannel: Improve port and declare dependency | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Danilo G. Baio <dbaio> | ||||||
| Component: | Individual Port(s) | Assignee: | Emanuel Haupt <ehaupt> | ||||||
| Status: | Closed FIXED | ||||||||
| Severity: | Affects Only Me | CC: | dbaio, ehaupt | ||||||
| Priority: | --- | Flags: | dbaio:
maintainer-feedback+
koobs: merge-quarterly+ |
||||||
| Version: | Latest | ||||||||
| Hardware: | Any | ||||||||
| OS: | Any | ||||||||
| Attachments: |
|
||||||||
Can you explain why you've added the use of bison? Hi Emanuel. I added iconv, localbase and ssl on this patch, then I reordered USES, bison came in on ports r386476. IIRC it wasn't building with byacc/yacc, that's why I added bison that time. And iconv was added because of 9.3 RELEASE: ====> Running Q/A tests (stage-qa) Error: /usr/local/bin/decode_emimsg is linked to /usr/local/lib/libiconv.so.2 from converters/libiconv but it is not declared as a dependency Warning: you need USES+=iconv The following come across as a bit odd, especially given this port is GNU_CONFIGURE=yes
CONFIGURE_ARGS= --with-cflags="${CPPFLAGS}" --with-libs="${LDFLAGS}" \
- cflags=CPPFLAGS (not =${CFLAGS}) ?
- libs=LDFLAGS (not =${LIBS}) ?
I'd be testing without these to see what the differences are in terms of dependency detection and linking, without USES=localbase which is widely scoped, and should only be used if absolutely necessary.
Created attachment 177964 [details] kannel-1.4.4_3_v02.patch Hi You caught a good point. Those options came in on ports r124568. I've made some tests with the attached patch and worked fine, since yesterday I am running kannel without problems as well. portlint: OK (looks fine.) testport: poudriere: i386, 9.3 (OK) poudriere: amd64, 9.3 (OK) poudriere: i386, 10.3 (OK) poudriere: amd64, 10.3 (OK) poudriere: i386, 11 (OK) poudriere: amd64, 11 (OK) poudriere: i386, 12 (OK) poudriere: amd64, 12 (OK) A commit references this bug: Author: ehaupt Date: Wed Dec 14 14:25:58 UTC 2016 New revision: 428563 URL: https://svnweb.freebsd.org/changeset/ports/428563 Log: - Document the iconv runtime dependency - Move from USE_OPENSSL to USES=ssl - Move from MYSQL_USE to MYSQL_USES - Bump PORTREVISION (because of dependency change) PR: 215133 Submitted by: dbaio@bsd.com.br (maintainer) MFH: 2016Q4 Changes: head/www/kannel/Makefile head/www/kannel/distinfo Thanks for the feedback, committed. Re-open pending MFH, assign to committer resolving MFH'd in r428631 [1] but was missing PR: 215133 reference so was not referenced here. [1] https://svnweb.freebsd.org/changeset/ports/428631 |
Created attachment 177774 [details] kannel-1.4.4_3.patch - Document iconv dependency - Switch to USES=localbase - Move from USE_OPENSSL to USES=ssl - Add TIMESTAMP on distinfo - Bump PORTREVISION portlint: OK (looks fine.) testport: poudriere: i386, 9.3 (OK) poudriere: amd64, 9.3 (OK) poudriere: i386, 10.3 (OK) poudriere: amd64, 10.3 (OK) poudriere: i386, 11 (OK) poudriere: amd64, 11 (OK) poudriere: i386, 12 (OK) poudriere: amd64, 12 (OK)