Summary: | [NEW PORT] textproc/ripgrep: Command line search tool | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | Ports & Packages | Reporter: | Petteri Valkonen <petteri.valkonen> | ||||||
Component: | Individual Port(s) | Assignee: | Tobias Kortkamp <tobik> | ||||||
Status: | Closed FIXED | ||||||||
Severity: | Affects Only Me | CC: | jsmith, tobik | ||||||
Priority: | --- | ||||||||
Version: | Latest | ||||||||
Hardware: | Any | ||||||||
OS: | Any | ||||||||
URL: | https://reviews.freebsd.org/D11162 | ||||||||
See Also: | https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=219916 | ||||||||
Attachments: |
|
Description
Petteri Valkonen
2016-12-11 12:59:34 UTC
This fails to build in Poudriere: =======================<phase: build >============================ ===> Building for ripgrep-0.3.2 cd /wrkdirs/usr/ports/textproc/ripgrep/work/ripgrep-0.3.2 && CARGO_HOME='/wrkdirs/usr/ports/textproc/ripgrep/work/.cargo' cargo build --release Updating registry `https://github.com/rust-lang/crates.io-index` warning: spurious network error (2 tries remaining): [12/-1] curl error: Could not resolve host: github.com warning: spurious network error (1 tries remaining): [12/-1] curl error: Could not resolve host: github.com error: failed to fetch `https://github.com/rust-lang/crates.io-index` To learn more, run the command again with --verbose. *** Error code 101 Stop. make: stopped in /usr/ports/textproc/ripgrep build of textproc/ripgrep ended at Fri Feb 24 16:05:57 CET 2017 build time: 00:00:10 !!! build failure encountered !!! [01:04:58] ====>> Error: Build failed in phase: build Created attachment 180374 [details]
Updated shar archive of textproc/ripgrep with no network access after 'fetch' phase
This updated version fixes a problem where devel/cargo would attempt to download dependencies during the 'build' phase. Dependencies are now packaged in a distfile created during the 'fetch' phase.
Also updates ripgrep to upstream version 0.4.0.
(In reply to petteri.valkonen from comment #2) The updated version builds fine in Poudriere but cannot be committed IMHO. I'm concerned that the tarballs you create in do-fetch will change between different builds and machines, plus their checksums are missing in distinfo. I have a similar situation with devel/stack (a Haskell build tool that uses Cabal during the build phase which also downloads dependencies), where I currently create my own tarball of stack's dependencies whenever I update the port. For lack of a better alternative and unless someone has a better idea, I suggest you roll your own tarball of the cargo registry (like you currently do in do-fetch), give it a proper version number, upload it somewhere, and make the port use it. OpenBSD does something similar though they have ports framework support for Cargo which makes this easier. (In reply to Tobias Kortkamp from comment #3) I've submitted a draft for a USES=cargo and have converted your port to use it. Let's see how this goes. *** Bug 219916 has been marked as a duplicate of this bug. *** A commit references this bug: Author: tobik Date: Wed Jun 21 16:23:53 UTC 2017 New revision: 444035 URL: https://svnweb.freebsd.org/changeset/ports/444035 Log: New port: textproc/ripgrep ripgrep is a command line search tool that combines the usability of The Silver Searcher (an ack clone) with the raw speed of GNU grep. ripgrep is fast, cross platform and written in Rust. WWW: http://blog.burntsushi.net/ripgrep/ PR: 215212 Submitted by: petteri.valkonen@iki.fi (based on) Approved by: mat (mentor) Differential Revision: https://reviews.freebsd.org/D11162 Changes: head/textproc/Makefile head/textproc/ripgrep/ head/textproc/ripgrep/Makefile head/textproc/ripgrep/distinfo head/textproc/ripgrep/pkg-descr Committed with the necessary changes for the new USES=cargo. :) |