Bug 215252

Summary:

audio/libbs2b: drop unused dependencies

Product:

Ports & Packages

Reporter:

Jan Beich <jbeich>

Component:

Individual Port(s)

Assignee:

Nikolai Lifanov <lifanov>

Status:

Closed FIXED

Severity:

Affects Only Me

CC:

liangtai.s16, lifanov

Priority:

---

Keywords:

patch, patch-ready

Version:

Latest

Flags:

bugzilla: maintainer-feedback? (liangtai.s16)

Hardware:

Any

OS:

Any

Bug Depends on:

170034

Bug Blocks:

Attachments:

Description	Flags
v1	none

Description Jan Beich freebsd_committer

2016-12-12 16:16:28 UTC

Created attachment 177914 [details]
v1

libbs2b doesn't directly link against anything but libsndfile. And none of supported FreeBSD releases bootleg indirect dependencies.

$ readelf -d /usr/local/lib/libbs2b.so | fgrep NEEDED
 0x0000000000000001 (NEEDED)             Shared library: [libc++.so.1]
 0x0000000000000001 (NEEDED)             Shared library: [libcxxrt.so.1]
 0x0000000000000001 (NEEDED)             Shared library: [libm.so.5]
 0x0000000000000001 (NEEDED)             Shared library: [libc.so.7]
 0x0000000000000001 (NEEDED)             Shared library: [libgcc_s.so.1]

$ readelf -d /usr/local/bin/bs2bconvert | fgrep NEEDED
 0x0000000000000001 (NEEDED)             Shared library: [libsndfile.so.1]
 0x0000000000000001 (NEEDED)             Shared library: [libbs2b.so.0]
 0x0000000000000001 (NEEDED)             Shared library: [libc.so.7]

Build logs:
10.1 i386  - http://sprunge.us/LXfd
10.3 amd64 - http://sprunge.us/IVST
11.0 i386  - http://sprunge.us/YJfZ
9.3 amd64  - http://sprunge.us/BWjQ
9.3 i386   - http://sprunge.us/XFId

Comment 1 Nikolai Lifanov freebsd_committer

2016-12-22 22:42:52 UTC

Committed, thanks!

Comment 2 commit-hook freebsd_committer

2016-12-22 22:43:12 UTC

A commit references this bug:

Author: lifanov
Date: Thu Dec 22 22:42:09 UTC 2016
New revision: 429192
URL: https://svnweb.freebsd.org/changeset/ports/429192

Log:
  audio/libbs2b: back out r301301

  /usr/bin/ld no longer pulls indirect dependencies.

  PR:		215252
  Submitted by:	jbeich
  Reviewed by:	matthew
  Approved by:	matthew (mentor), liangtai.s26@gmail.com (maintainer timeout)
  Differential Revision:	https://reviews.freebsd.org/D8885

Changes:
  head/audio/libbs2b/Makefile