Bug 215317

Summary: [patch] www/zend-framework1: Make memcache dependency optional
Product: Ports & Packages Reporter: Fredrik Eriksson <fredrik.eriksson>
Component: Individual Port(s)Assignee: Walter Schwarzenfeld <w.schwarzenfeld>
Status: Closed Overcome By Events    
Severity: Affects Only Me CC: w.schwarzenfeld
Priority: --- Keywords: patch
Version: LatestFlags: bugzilla: maintainer-feedback? (wg)
Hardware: Any   
OS: Any   
Attachments:
Description Flags
Patch to make memcache dependency optional none

Description Fredrik Eriksson 2016-12-15 09:30:12 UTC
Created attachment 177982 [details]
Patch to make memcache dependency optional

This is basically the same issue as #213384, but against www/zend-framework1 instead of www/zend-framework.

From #213384:

At the moment databases/pecl-memcache and databases/pecl-memcached are always pulled in as run dependencies for the zend-framework port. However, as far as I can tell it has never been a hard requirement to have the memcache extensions to use the non-memcache parts of zend-framework.

The attached patch adds an MEMCACHE option to the port and will only pull in the memcache-dependencies if this option is set.

The MEMCACHE option is off by default in my patch. I think that is a saner default, but it may (obviously) break stuff that rely on the current port behaviour, so I guess that's up for discussion.


The reason I stumbled on this is because the pecl-memcache ports are not compatible with PHP7 (#208049, #207295), while zend-framework should be. So right now this is mostly a workaround for me to build zend-framework with PHP7.
Comment 1 Walter Schwarzenfeld 2018-01-12 10:53:29 UTC
Maintainer feedback? (Maintainer timeout ?).
Comment 2 Walter Schwarzenfeld 2018-03-08 06:21:26 UTC
Makefile shows:
.if ${PORT_OPTIONS:MMEMCACHE}
USE_PHP+=       memcache memcached
.endif

It is done, so I close here.