Bug 215326

Summary: [PATCH] finance/p5-Finance-Quote: missing dependency
Product: Ports & Packages Reporter: Guido Falsi <madpilot>
Component: Individual Port(s)Assignee: Po-Chuan Hsieh <sunpoet>
Status: Closed FIXED    
Severity: Affects Only Me CC: sunpoet
Priority: --- Keywords: patch
Version: LatestFlags: bugzilla: maintainer-feedback? (sunpoet)
Hardware: Any   
OS: Any   
Attachments:
Description Flags
p5-Finance-Quote.diff madpilot: maintainer-approval? (sunpoet)

Description Guido Falsi freebsd_committer freebsd_triage 2016-12-15 18:09:35 UTC
Created attachment 177997 [details]
p5-Finance-Quote.diff

Present port fails from gnucash with the following error:

> gnc-fq-check
Can't locate CGI.pm in @INC (you may need to install the CGI module) (@INC contains: /usr/local/lib/perl5/site_perl/mach/5.24 /usr/local/lib/perl5/site_perl /usr/local/lib/perl5/5.24/mach /usr/local/lib/perl5/5.24 .) at /usr/local/lib/perl5/site_perl/Finance/Quote/AEX.pm line 45.
BEGIN failed--compilation aborted at /usr/local/lib/perl5/site_perl/Finance/Quote/AEX.pm line 45.
Compilation failed in require at (eval 11) line 1.
BEGIN failed--compilation aborted at (eval 11) line 1.
 at /usr/local/bin/gnc-fq-check line 91.
Can't locate object method "methods" via package "Finance::Quote::AEX" at /usr/local/lib/perl5/site_perl/Finance/Quote.pm line 119.


Adding a dependency on www/p5-CGI makes it work fine again.

Patch attached.
Comment 1 commit-hook freebsd_committer freebsd_triage 2016-12-17 12:58:40 UTC
A commit references this bug:

Author: sunpoet
Date: Sat Dec 17 12:57:23 UTC 2016
New revision: 428736
URL: https://svnweb.freebsd.org/changeset/ports/428736

Log:
  - Update LICENSE
  - Add LICENSE_FILE
  - Fix *_DEPENDS: add missing p5-CGI [1], p5-HTML-Parser and p5-HTTP-Cookies
  - Bump PORTREVISION for dependency change

  PR:		215326 [1]
  Submitted by:	madpilot [1]

Changes:
  head/finance/p5-Finance-Quote/Makefile
Comment 2 Po-Chuan Hsieh freebsd_committer freebsd_triage 2016-12-17 13:07:59 UTC
Committed. Thanks!