Bug 215369
| Summary: | devel/kBuild: Re-allow building with clang [patch] | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Adam Weinberger <adamw> | ||||
| Component: | Individual Port(s) | Assignee: | Virtualbox Team (Nobody) <vbox> | ||||
| Status: | Closed FIXED | ||||||
| Severity: | Affects Only Me | CC: | tobik, w.schwarzenfeld | ||||
| Priority: | --- | Keywords: | patch | ||||
| Version: | Latest | Flags: | bugzilla:
maintainer-feedback?
(vbox) |
||||
| Hardware: | Any | ||||||
| OS: | Any | ||||||
| Attachments: |
|
||||||
Maintainer feedback,please! (In reply to Adam Weinberger from comment #0) This is also very useful when building a package repository only with kernel modules in Poudriere. With this I'm not forced to also build GCC when only building virtualbox-ose-kmod which builds fine with Clang. Is there a reason this wasn't committed with maintainer timeout yet? (In reply to Tobias Kortkamp from comment #2) I've been holding out hope for 18 months now that someone from the vbox team will take 30 seconds to reply to this PR, but you're right, Tobias, that's probably not going to happen. A commit references this bug: Author: adamw Date: Fri May 18 15:41:56 UTC 2018 New revision: 470301 URL: https://svnweb.freebsd.org/changeset/ports/470301 Log: devel/kBuild: Add a GCC option When you're building only virtualbox-ose-additions, and without any X-related stuff, it is sufficient to build with clang instead of GCC. Add a GCC option (with a warning and pkg-help saying to leave it enabled) to make GCC optional. PR: 215369 Approved by: maintainer timeout (17 months) Changes: head/devel/kBuild/Makefile head/devel/kBuild/pkg-help Committed after timeout |
Created attachment 178042 [details] GCC option For very simple uses, GCC isn't required for kBuild. Under most circumstances it is, but when you only need virtualbox-ose-additions without X11 and you're on amd64/i386, GCC isn't necessary. It would be really nice not to have to build GCC and all its dependencies. The attached patch makes GCC optional, and enabled by default, with warnings that it should only be disabled under specific circumstances (with a pkg-help file to spell out what those circumstances are).