Bug 215402

Summary: multimedia/ffmpeg: only use vendor optimizations, dropping -ffast-math
Product: Ports & Packages Reporter: Jan Beich <jbeich>
Component: Individual Port(s)Assignee: Thomas Zander <riggs>
Status: Closed FIXED    
Severity: Affects Only Me CC: riggs
Priority: --- Keywords: patch
Version: LatestFlags: riggs: maintainer-feedback+
Hardware: Any   
OS: Any   
Description Flags
v0 none

Description Jan Beich freebsd_committer 2016-12-19 03:37:07 UTC
Created attachment 178083 [details]

configure has --enable-optimizations (default) which includes -O3 -fomit-frame-pointer. Together with unconditional stripping it breaks unwinding as used by pmcstat/dtrace or -fsanitize=address. Rather than add PROFILE option let's use OPTIMIZED_CFLAGS to control vendor optimizations. But doing so induces POLA as -ffast-math from ports r69328 would contaminate defaults or left out.

In my opinion, extra optimization flags should not leave make.conf. Vendor doesn't test those, so having in port adds to maintenance to check with clang/gcc or on different release/architecture tuples.
Comment 1 Thomas Zander freebsd_committer 2016-12-31 16:23:27 UTC
Valid point, especially given how much time has passed since ports r69328 . Let me test this a bit, okay?
Comment 2 commit-hook freebsd_committer 2017-01-01 18:47:58 UTC
A commit references this bug:

Author: riggs
Date: Sun Jan  1 18:47:01 UTC 2017
New revision: 430269
URL: https://svnweb.freebsd.org/changeset/ports/430269

  Modernise handling of OPTIMIZED_CFLAGS

  - Use vendor-selected OPTIMIZED_CFLAGS
  - Add them to OPTIONS_DEFAULT

  PR:		215402
  Submitted by:	jbeich

Comment 3 commit-hook freebsd_committer 2017-01-01 18:49:01 UTC
A commit references this bug:

Author: riggs
Date: Sun Jan  1 18:48:11 UTC 2017
New revision: 430270
URL: https://svnweb.freebsd.org/changeset/ports/430270

  Reflect changes to OPTIMIZED_CFLAGS handling in multimedia/ffmpeg

  PR:		215402
  Submitted by:	jbeich

Comment 4 Thomas Zander freebsd_committer 2017-01-01 18:57:40 UTC
Thumbs up!