Bug 215463
| Summary: | [NEW PORT] sysutils/paladin: A simple process supervisor | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Randy Westlund <rwestlun> | ||||||
| Component: | Individual Port(s) | Assignee: | Raphael Kubo da Costa <rakuco> | ||||||
| Status: | Closed FIXED | ||||||||
| Severity: | Affects Only Me | CC: | rakuco | ||||||
| Priority: | --- | ||||||||
| Version: | Latest | ||||||||
| Hardware: | Any | ||||||||
| OS: | Any | ||||||||
| Attachments: |
|
||||||||
I'm not very familiar with Go or how Go ports work, so here are a few generic comments: - portlint is complaining about your COMMENT line: WARN: Makefile: COMMENT is not supposed to begin with 'A ', 'An ', or 'The '. - In general, if you set LICENSE, you should also set LICENSE_FILE. - Isn't it possible to drop your do-build target by passing the -ldflags bit in CGO_CFLAGS or CGO_LDFLAGS? Created attachment 178774 [details]
Updated new port
Thanks for taking a look. I've fixed COMMENT and added LICENSE_FILE.
I tried using CGO_LDFLAGS before deciding to override do-build, but I couldn't get it working. I only have a rudimentary understanding of this myself, but I'm pretty sure the -ldflags bit needs to be an argument to the Go command, rather than an environment variable.
I looked at a lot of other Go ports in the tree; overriding do-build for reasons like this seems to be pretty common.
A commit references this bug: Author: rakuco Date: Fri Jan 13 17:59:55 UTC 2017 New revision: 431409 URL: https://svnweb.freebsd.org/changeset/ports/431409 Log: New port: sysutils/paladin Simple process supervisor. WWW: https://github.com/rwestlund/paladin PR: 215463 Submitted by: Randy Westlund <rwestlun@gmail.com> Changes: head/sysutils/Makefile head/sysutils/paladin/ head/sysutils/paladin/Makefile head/sysutils/paladin/distinfo head/sysutils/paladin/pkg-descr head/sysutils/paladin/pkg-message head/sysutils/paladin/pkg-plist Committed at last, thank you for the port! Sidebar: while I don't have problems with new ports being sent as patch files, do note that the official procedure says they should be sent as .shar files. Keep that in mind to avoid issues with other committers in the future :-) Thanks! The handbook says either is acceptable now. I think it's a recent change, because I remember my first port being a shar. Personally, I find patches much easier to work with. https://www.freebsd.org/doc/en/books/porters-handbook/porting-submitting.html |
Created attachment 178172 [details] New port New port attached.