Bug 215532

Summary:

games/minetest: Fix movement when built with clang 3.8+

Product:

Ports & Packages

Reporter:

Sean Farley <scf>

Component:

Individual Port(s)

Assignee:

Dmitry Marakasov <amdmi3>

Status:

Closed FIXED

Severity:

Affects Some People

Flags:

bugzilla: maintainer-feedback? (amdmi3)

Priority:

---

Version:

Latest

Hardware:

Any

OS:

Any

Attachments:

Description	Flags
Patch to remove -ffast-math flag from build	none

Description Sean Farley freebsd_committer

2016-12-24 02:59:06 UTC

Created attachment 178242 [details]
Patch to remove -ffast-math flag from build

After a short period of time (seconds to less than a minute), movement within the game using the keyboard no longer works.  The issue is fixed by removing the -ffast-math flag.  While the issue does not appear with GCC, it does with Clang.

Upstream has removed the flag from the release builds starting with v0.4.16 (in development).  The issue is detailed here:  https://github.com/minetest/minetest/issues/4274

The recently release v0.4.15 still has the issue, so when the port is updated to that version, this fix still needs to be present.

Comment 1 Dmitry Marakasov freebsd_committer

2016-12-24 15:08:51 UTC

Thanks, I was just about to update the port. Will apply the fix. The same problem seem to plague freeminer, might fix it as well.

Comment 2 commit-hook freebsd_committer

2016-12-24 16:37:35 UTC

A commit references this bug:

Author: amdmi3
Date: Sat Dec 24 16:37:22 UTC 2016
New revision: 429371
URL: https://svnweb.freebsd.org/changeset/ports/429371

Log:
  - Update to 0.4.15
  - Remove -ffast-math to fix problems when built with clang 3.8+ ([1])

  PR:		215532 [1]
  Submitted by:	scf [1]

Changes:
  head/games/minetest/Makefile
  head/games/minetest/distinfo
  head/games/minetest/files/patch-src_CMakeLists.txt
  head/games/minetest/pkg-plist

Comment 3 Sean Farley freebsd_committer

2016-12-25 04:25:33 UTC

(In reply to Dmitry Marakasov from comment #1)

It works great.  Thank you!