Bug 215670

Summary: security/p5-openxpki, security/p5-openxpki-i18n: update to 1.16.2
Product: Ports & Packages Reporter: Sergei Vyshenski <svysh.fbsd>
Component: Individual Port(s)Assignee: Po-Chuan Hsieh <sunpoet>
Status: Closed FIXED    
Severity: Affects Some People CC: svysh.fbsd
Priority: ---    
Version: Latest   
Hardware: Any   
OS: Any   
Bug Depends on: 214293    
Bug Blocks:    
Attachments:
Description Flags
patch for updating the ports
svysh.fbsd: maintainer-approval+
patch for updating the ports
svysh.fbsd: maintainer-approval+
patch for updating the ports svysh.fbsd: maintainer-approval+

Description Sergei Vyshenski 2016-12-30 13:51:31 UTC 
Created attachment 178395 [details]
patch for updating the ports

- Update 2 ports sharing the same distribution tarball:
   security/p5-openxpki
   security/p5-openxpki-i18n
     1.12.0 --> 1.16.2
Changes: https://github.com/openxpki/openxpki/releases/tag/v1.16.2

- new port is needed as a build and run dependency:
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=214293

- add control of service dirs existence, mode and ownership -
to the rc.d script files/openxpki.in via *_precmd functions

- remove control of service dirs mode and ownership from the pkg-plist 

- After running "make makeplist" I had to add by hand 256 lines starting with
%%PORTEXAMPLES%%%%EXAMPLESDIR%%/ to the file pkg-plist, to make poudriere happy.

- During build, warns are issued about possible redundant use of 
modules from perl core:
1) openxpki really needs versions, which are not present in perl core yet
	www/p5-CGI-Fast>=2.10
	www/p5-CGI>=4.21
2) lang/p5-Switch is not in perl core for all supported versions of perl.

- remove stuff not supported by FreeBSD by means of files/patch-Makefile.PL

- "portlint -AC" gives just non-relevant warnings.

- Tested OK at 11-stable-amd64 with poudriere-3.1.14, perl-5.24.1, and openssl from base.
Comment 1 Sergei Vyshenski 2017-01-07 23:37:15 UTC 
Created attachment 178614 [details]
patch for updating the ports

rclint -v files/openxpki.in
recommends using "install" rather than "chown".
But here we need a more fine control of starting server, than "install" provides, 
because configuration files have to be created by hand.
Comment 2 Po-Chuan Hsieh freebsd_committer freebsd_triage 2017-01-08 00:53:57 UTC 
I'd suggest/recommend:
- Sort *_DEPENDS
- Remove blank line between BUILD_DEPENDS and RUN_DEPENDS
- Remove PERL_LEVEL check as we do not have perl5.18 in the tree
- Remove OXLIB and use the shared library path right after STRIP_CMD
- Use PORTEXAMPLES to simplify PLIST
Comment 3 Sergei Vyshenski 2017-01-08 02:30:32 UTC 
Created attachment 178615 [details]
patch for updating the ports

Thanks. Patch fixed as recommended. Tested anew as before.
Comment 4 commit-hook freebsd_committer freebsd_triage 2017-01-08 20:45:29 UTC 
A commit references this bug:

Author: sunpoet
Date: Sun Jan  8 20:43:46 UTC 2017
New revision: 430896
URL: https://svnweb.freebsd.org/changeset/ports/430896

Log:
  Update to 1.16.2

  - Sort *_DEPENDS
  - Remove blank line between BUILD_DEPENDS and RUN_DEPENDS
  - Remove OXLIB and use the shared library path right after STRIP_CMD
  - Use PORTEXAMPLES to simplify PLIST
  - While I'm here, fix indent

  Changes:	https://github.com/openxpki/openxpki/commits/develop
  PR:		215670
  Submitted by:	Sergei Vyshenski <svysh.fbsd@gmail.com> (maintainer)

Changes:
  head/security/p5-openxpki/Makefile
  head/security/p5-openxpki/distinfo
  head/security/p5-openxpki/files/openxpki.in
  head/security/p5-openxpki/files/patch-Makefile.PL
  head/security/p5-openxpki/pkg-plist
  head/security/p5-openxpki-i18n/Makefile
  head/security/p5-openxpki-i18n/distinfo
Comment 5 Po-Chuan Hsieh freebsd_committer freebsd_triage 2017-01-08 20:46:13 UTC 
Committed. Thanks!