Bug 215671
| Summary: | [maintainer-update] games/chocolate-doom 2.2.1 to 2.3.0 | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | jakub_lach | ||||||||
| Component: | Individual Port(s) | Assignee: | Torsten Zuehlsdorff <tz> | ||||||||
| Status: | Closed FIXED | ||||||||||
| Severity: | Affects Only Me | CC: | tz | ||||||||
| Priority: | --- | ||||||||||
| Version: | Latest | ||||||||||
| Hardware: | Any | ||||||||||
| OS: | Any | ||||||||||
| Attachments: |
|
||||||||||
The patch fails a stage-qa: ====> Running Q/A tests (stage-qa) ====> Checking for pkg-plist issues (check-plist) ===> Parsing plist ===> Checking for items in STAGEDIR missing from pkg-plist Error: Orphaned: %%PORTDOCS%%%%DOCSDIR%%/NEWS.md Error: Orphaned: %%PORTDOCS%%%%DOCSDIR%%/NOT-BUGS.md Error: Orphaned: %%PORTDOCS%%%%DOCSDIR%%/PHILOSOPHY.md Error: Orphaned: %%PORTDOCS%%%%DOCSDIR%%/README.Music.md Error: Orphaned: %%PORTDOCS%%%%DOCSDIR%%/README.md ===> Checking for items in pkg-plist which are not in STAGEDIR Error: Missing: %%DOCSDIR%%/NEWS Error: Missing: %%DOCSDIR%%/NOT-BUGS Error: Missing: %%DOCSDIR%%/PHILOSOPHY Error: Missing: %%DOCSDIR%%/README Error: Missing: %%DOCSDIR%%/README.Music ===> Error: Plist issues found. *** Error code 1 Can you please check it again? Also please create the diff against the port or the ports-tree, not against the full path of /usr/ports/. Most committer have ports-tree located in another directory. So i needed to adjust the paths in the patch manually. Greetings, Torsten I've manually removed plist entries starting with %%PORTDOCS%%%%DOCSDIR%% as was done prior with earlier versions. Could you check 2.2.1 too? They both pass % make stage && make check-plist && make stage-qa && make package here, maybe diff got broken? Created attachment 178504 [details]
2.2.1 to 2.3.0 patch v2
Thanks for the updated patch - this was much easier :) But the problems still stand. make check-plist raises the errors quoted above. Did you try a "make clean" at the beginning? I can reproduce the errors manually and via poudriere. DOCS is unset here be default. I will check that. Created attachment 178515 [details]
2.2.1 to 2.3.0 patch v3
I've finally reproduced the problem and it should be corrected now, sorry for the hiccup.
A commit references this bug: Author: tz Date: Wed Jan 4 16:52:11 UTC 2017 New revision: 430577 URL: https://svnweb.freebsd.org/changeset/ports/430577 Log: games/chocolate-doom: Update from 2.2.1 to 2.3.0 Changelog: https://github.com/chocolate-doom/chocolate-doom/releases/tag/chocolate-doom-2.3.0 PR: 215671 Submitted by: jakub_lach@mailplus.pl (maintainer) Changes: head/games/chocolate-doom/Makefile head/games/chocolate-doom/distinfo head/games/chocolate-doom/pkg-plist Now it works! Committed, thanks! |
Created attachment 178397 [details] 2.2.1 to 2.3.0 patch Not many changes. * Added png dependency as suggested per % make stage && make check-plist && make stage-qa && make package process. * I do not use bash-completion so I'm unsure where do we want these.