Bug 215762

Summary: Bhyve subsection of Handbook fails to mention UEFI and framebuffer
Product: Documentation Reporter: Dmitrij D. Czarkoff <czarkoff>
Component: Books & ArticlesAssignee: Michael Dexter <dexter>
Status: Closed FIXED    
Severity: Affects Some People CC: allanjude, bcr, murray, wblock
Priority: --- Keywords: patch
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
Git patch against current handbook source
none
Suggested supplementary patch
none
Updated patch
none
Updated diff against Benedict's last one none

Description Dmitrij D. Czarkoff 2017-01-04 12:05:32 UTC
Created attachment 178502 [details]
Git patch against current handbook source

Bhyve in FreeBSD 11 is capable of UEFI emulation, which may come handy with some guest operating systems.  This patch introduces some basic description of functionality.
Comment 1 Dmitrij D. Czarkoff 2017-03-05 09:38:40 UTC
Ping.
Comment 2 Michael Dexter freebsd_committer freebsd_triage 2017-03-17 07:24:21 UTC
Created attachment 180895 [details]
Suggested supplementary patch

The following supplementary patch reflects my suggestions.
Comment 3 Michael Dexter freebsd_committer freebsd_triage 2017-03-17 07:25:21 UTC
I have added a supplementary patch. (Apply the first, apply my second.)
Comment 4 Michael Dexter freebsd_committer freebsd_triage 2017-03-17 07:29:59 UTC
Ping bcr@ (Mentor)
Comment 5 Benedict Reuschling freebsd_committer freebsd_triage 2017-03-17 13:06:25 UTC
I applied the patches in order, but the second one did not apply cleanly.

Patching file chapter.xml using Plan A...
Hunk #1 succeeded at 91.
Hunk #2 failed at 971.
Hunk #3 succeeded at 1247 with fuzz 1 (offset 72 lines).
1 out of 3 hunks failed--saving rejects to chapter.xml.rej
done

cat chapter.xml.rej yields:

@@ -971,9 +971,9 @@
       <acronym>BSD</acronym>-licensed hypervisor became part of the
       base system with &os; 10.0-RELEASE.  This hypervisor supports a
       number of guests, including &os;, OpenBSD, and many &linux;
-      distributions.  Currently, <application>bhyve</application> only
-      supports a serial console and does not emulate a graphical
-      console.  Virtualization offload features of newer
+      distributions.  By default, <application>bhyve</application>
+      provides access to serial console and does not emulate a
+      graphical console.  Virtualization offload features of newer
       <acronym>CPU</acronym>s are used to avoid the legacy methods of
       translating instructions and manually managing memory
       mappings.</para>

Can you fix that?
Comment 6 Benedict Reuschling freebsd_committer freebsd_triage 2017-03-17 13:42:30 UTC
Created attachment 180902 [details]
Updated patch

I've found that when I just apply Dexter's patch, it applies cleanly. I made some corrections and cleanups. I ran it through textproc/igor, but was not sure about wrapping the <option> tags. Some grammar and textual fixes are still required.
Comment 7 Michael Dexter freebsd_committer freebsd_triage 2017-03-22 17:00:27 UTC
Created attachment 181063 [details]
Updated diff against Benedict's last one

Based on Benedict's requests.
Comment 8 commit-hook freebsd_committer freebsd_triage 2017-03-28 00:09:35 UTC
A commit references this bug:

Author: dexter
Date: Tue Mar 28 00:09:27 UTC 2017
New revision: 50094
URL: https://svnweb.freebsd.org/changeset/doc/50094

Log:
  Add UEFI section to the Virtualization chapter

  PR:		215762
  Submitted by:	czarkoff@gmail.com
  Approved by:	bcr (mentor)

Changes:
  head/en_US.ISO8859-1/books/handbook/virtualization/chapter.xml
Comment 9 Michael Dexter freebsd_committer freebsd_triage 2017-03-28 00:27:37 UTC
Thank you Dmitrij!

I have submitted this with the input and review of bcr@