Bug 215776
| Summary: | www/node6: Update to v6.9.4 | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Bradley T. Hughes <bhughes> | ||||||||
| Component: | Individual Port(s) | Assignee: | Po-Chuan Hsieh <sunpoet> | ||||||||
| Status: | Closed FIXED | ||||||||||
| Severity: | Affects Many People | ||||||||||
| Priority: | --- | ||||||||||
| Version: | Latest | ||||||||||
| Hardware: | Any | ||||||||||
| OS: | Any | ||||||||||
| URL: | https://nodejs.org/en/blog/release/v6.9.4/ | ||||||||||
| Attachments: |
|
||||||||||
testport: OK (poudriere, 11.0-R, 10.3-R, amd64/i386, default options) testport: OK (poudriere, 11.0-R, 10.3-R, amd64/i386, BUNDLED_SSL) (In reply to Bradley T. Hughes from comment #0) IMHO, pkg-message change in this PR is mainly for package users. But it is incorrect for ports users since they could build any www/npm* with NODE6 option if they want. (In reply to Po-Chuan Hsieh from comment #2) Yes, that's correct, I wanted to help pkg users by not using a port/package that depends on www/node by default. But ports users also see this message. (In reply to Po-Chuan Hsieh from comment #4) Yes, they do, and the message is still valid with the default options. I can try to formulate the message so that it informs port users that they can use any of the www/npm* ports, if you like. As it is, though, it's wrong for pkg users, which I wanted to address. I postponed node4 and node6 update for pkg-message change. How about: Note: If you need npm (Node Package Manager), please install www/npm3 package. Or you could build npm (any of www/npm* port) with NODE6 option enabled. (In reply to Po-Chuan Hsieh from comment #7) I was going to suggest this: Note: If you need npm (Node Package Manager), please install the npm3 package, or build any of the www/npm* ports with the NODE6 option enabled. Created attachment 178556 [details]
www/node6 with updated pkg-message
New patch with updated pkg-message.
Created attachment 178569 [details]
v6.9.4
The v6.9.3 release tarballs were inadvertently replaced, so upstream has released a new v6.9.4 version with zero changes. Updated the patch to use the latest version and address comments so far. Thanks for the help so far! :)
A commit references this bug: Author: sunpoet Date: Fri Jan 6 20:02:50 UTC 2017 New revision: 430744 URL: https://svnweb.freebsd.org/changeset/ports/430744 Log: Update to 6.9.4 - Update pkg-message - While I'm here, remove duplicate PLIST_SUB which is already handled by OPTIONS_SUB=yes Changes: https://github.com/nodejs/node/blob/master/doc/changelogs/CHANGELOG_V6.md https://nodejs.org/en/blog/release/v6.9.4/ PR: 215776 Submitted by: Bradley T. Hughes <bradleythughes@fastmail.fm> (maintainer) Changes: head/www/node6/Makefile head/www/node6/distinfo head/www/node6/files/patch-node.gyp head/www/node6/pkg-message Committed. Thanks! Thanks! :) |
Created attachment 178521 [details] v6.9.3 Update to the latest upstream release. Remove files/patch-node.gyp as the problem addressed by this patch has been fixed upstream. Update pkg-message to refer uses to www/npm3 if they need npm, since www/npm3 depends on www/node6 by default. portlint: OK (-C, spurious warning about possible direct use of "python")