Bug 215844

Summary:	Dashboard query: Ports bugs, that are ready to be taken by a committer: no longer effective
Product:	Services	Reporter:	John Hein <jcfyecrayz>
Component:	Bug Tracker	Assignee:	Bugmeister <bugmeister>
Status:	Closed FIXED
Severity:	Affects Some People	CC:	grahamperrin
Priority:	---
Version:	unspecified
Hardware:	Any
OS:	Any
See Also:	https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=227147

Description John Hein 2017-01-06 23:16:47 UTC

At the time I write this the bugzilla "Dashboard" is showing just one port that is matched by the pre-canned query for "Ports bugs, that are ready to be taken by a committer".

That's definitely not accurate.  I suppose it's because the query relies on the "patch-ready" keyword and that keyword is not on enough bugs.  I wasn't able to dig up information on patch-ready, however, to determine why more ports are not labeled with it.  The keyword field appears to be read-only for me.

Is there a procedure I've missed to encourage a committer to process a bug that's ready to go?  Or is there just a triage / committer bandwidth shortage?

Comment 1 Graham Perrin freebsd_committer

2022-10-30 01:03:46 UTC

For me, now: neither <https://bugs.freebsd.org/bugzilla/page.cgi?id=dashboard.html> nor <https://bugs.freebsd.org/bugzilla/userprefs.cgi?tab=saved-searches> includes 'ready for committer'. 

Close, overcome by events?

Comment 2 Graham Perrin freebsd_committer

2022-12-30 01:07:23 UTC

Please ignore my comment 1. 


(In reply to John Hein from comment #0)

> … not on enough bugs. …

The keyword became deprecated, by bug 227147, some time after this bug 215844 was reported. 

Removing the keyword, from bugs found by the query, will cause the query to find nothing.

Current search criteria for the query: 


Status: New, Open, In Progress, UNCONFIRMED

Product: Ports & Packages

Assignee: ports-bugs@FreeBSD.org

Keywords: patch-ready

Comment 3 Graham Perrin freebsd_committer

2022-12-30 01:07:48 UTC

*** Bug 268651 has been marked as a duplicate of this bug. ***

Comment 4 Graham Perrin freebsd_committer

2022-12-30 11:09:57 UTC

(In reply to John Hein from comment #0)

John, if you like, try the query that I added to <https://wiki.freebsd.org/Bugzilla/SearchQueries>: 

    all open, non-obsolete patch, maintainer-approval +

Comment 5 John Hein 2023-01-02 21:38:13 UTC

(In reply to Graham Perrin from comment #4)
The 'shared search' fails ("The search named all open, non-obsolete patch, maintainer-approval + has not been made visible to you.").

But the 'public search' does come up with a list of bugs.  That seems like a reasonable replacement for the current "read to be taken by a committer" dasboard link.

Comment 6 Graham Perrin freebsd_committer

2023-01-13 14:34:51 UTC

(In reply to John Hein from comment #5)

Under <https://wiki.freebsd.org/Bugzilla/SearchQueries#Ports_Searches> I added two queries, and struck through one that does not work. The two additions: 


maintainer-approval +, non-obsolete patch, open or in progress, assigned to ports-bugs@ (not yet assigned to a person)

maintainer-approval +, non-obsolete patch, new (not triaged), assigned to ports-bugs@


The phrases are descriptive, but not particularly user-friendly. Results from the first of the two might come close to what's required, the query named: 

> Ports bugs, that are ready to be taken by a committer

Comment 7 Mark Linimon freebsd_committer

2023-12-01 09:43:21 UTC

^Triage: close.

I'm sorry that I never came across this before.  But it's true that the query was OBE.  I've removed it.