Bug 216015

Summary:

www/webkit-qt4: fails to build with clang 4.0

Product:

Ports & Packages

Reporter:

Jan Beich <jbeich>

Component:

Individual Port(s)

Assignee:

freebsd-kde (group) <kde>

Status:

Closed FIXED

Severity:

Affects Only Me

Keywords:

needs-patch

Priority:

---

Flags:

jbeich: maintainer-feedback? (kde)

Version:

Latest

Hardware:

Any

OS:

Any

See Also:

Bug Depends on:

Bug Blocks:

216008

Attachments:

Description	Flags
v0	none

Description Jan Beich freebsd_committer

2017-01-13 07:40:43 UTC

html/HTMLImageElement.cpp:77:24: error: ordered comparison between pointer and zero ('const int *' and 'int')
    if (optionalHeight > 0)
        ~~~~~~~~~~~~~~ ^ ~

build log: http://sprunge.us/XIbJ
regressed by: https://github.com/llvm-mirror/clang/commit/4b6ad14285f3

Comment 1 Jan Beich freebsd_committer

2017-01-14 04:11:55 UTC

Created attachment 178871 [details]
v0

Based on https://github.com/WebKit/webkit/commit/b338d3572c67#diff-604e2ee68a3013780a8c77e6c489641aR76

Comment 2 commit-hook freebsd_committer

2017-01-17 14:38:58 UTC

A commit references this bug:

Author: jbeich
Date: Tue Jan 17 14:37:56 UTC 2017
New revision: 431742
URL: https://svnweb.freebsd.org/changeset/ports/431742

Log:
  www/webkit-qt4: unbreak with clang 4.0

  html/HTMLImageElement.cpp:77:24: error: ordered comparison between pointer and zero ('const int *' and 'int')
      if (optionalHeight > 0)
          ~~~~~~~~~~~~~~ ^ ~

  PR:		216015
  Regressed by:	https://github.com/llvm-mirror/clang/commit/4b6ad14285f3
  Obtained from:	upstream (excerpt)
  Approved by:	portmgr blanket

Changes:
  head/www/webkit-qt4/files/patch-src_3rdparty_webkit_Source_WebCore_html_HTMLImageElement.cpp

Comment 3 commit-hook freebsd_committer

2017-01-19 05:23:42 UTC

A commit references this bug:

Author: jbeich
Date: Thu Jan 19 05:23:15 UTC 2017
New revision: 431846
URL: https://svnweb.freebsd.org/changeset/ports/431846

Log:
  MFH: r431742

  www/webkit-qt4: unbreak with clang 4.0

  html/HTMLImageElement.cpp:77:24: error: ordered comparison between pointer and zero ('const int *' and 'int')
      if (optionalHeight > 0)
          ~~~~~~~~~~~~~~ ^ ~

  PR:		216015
  Regressed by:	https://github.com/llvm-mirror/clang/commit/4b6ad14285f3
  Obtained from:	upstream (excerpt)
  Approved by:	portmgr blanket
  Approved by:	ports-secteam blanket

Changes:
_U  branches/2017Q1/
  branches/2017Q1/www/webkit-qt4/files/patch-src_3rdparty_webkit_Source_WebCore_html_HTMLImageElement.cpp

Comment 4 commit-hook freebsd_committer

2017-02-01 05:30:20 UTC

A commit references this bug:

Author: jbeich
Date: Wed Feb  1 05:29:19 UTC 2017
New revision: 432987
URL: https://svnweb.freebsd.org/changeset/ports/432987

Log:
  graphics/copperspice: unbreak with clang 4.0

  ../3rdparty/webkit/Source/WebCore/html/HTMLImageElement.cpp:77:24: error: ordered comparison between pointer and zero ('const int *' and 'int')
      if (optionalHeight > 0)
          ~~~~~~~~~~~~~~ ^ ~

  PR:		216015
  Reported by:	antoine (via exp-run)
  Obtained from:	upstream (excerpt)

Changes:
  head/graphics/copperspice/files/patch-src_3rdparty_webkit_Source_WebCore_html_HTMLImageElement.cpp