Bug 216032

Summary: shells/fish No matches for wildcard '$PATH/mount.*'.
Product: Ports & Packages Reporter: Martin Filla <freebsd>
Component: Individual Port(s)Assignee: Alan Somers <asomers>
Status: Closed FIXED    
Severity: Affects Only Me Flags: asomers: maintainer-feedback+
Priority: ---    
Version: Latest   
Hardware: i386   
OS: Any   
Attachments:
Description Flags
Fix __fish__print__filesystems.fish none

Description Martin Filla 2017-01-13 14:34:00 UTC
Hello 

For command mount -t and i want filesystem for mount usb 
fish print this:

xxxx@ ~> mount -tNo matches for wildcard '$PATH/mount.*'.
/usr/local/share/fish/functions/__fish_print_filesystems.fish (line 1): string replace -ra ".*/mount." "" -- $PATH/mount.*
                                                                                                             ^
in command substitution
	called on line 1 of file /usr/local/share/fish/functions/__fish_print_filesystems.fish

in function '__fish_print_filesystems'
	called on standard input

in command substitution
	called on standard input

xxxx@ ~> mount -t No matches for wildcard '$PATH/mount.*'.
/usr/local/share/fish/functions/__fish_print_filesystems.fish (line 1): string replace -ra ".*/mount." "" -- $PATH/mount.*
                                                                                                             ^
in command substitution
	called on line 1 of file /usr/local/share/fish/functions/__fish_print_filesystems.fish

in function '__fish_print_filesystems'
	called on standard input

in command substitution
	called on standard input

xxxx@ ~> mount -t msdos 
xxxx@ ~> mount -t msdNo matches for wildcard '$PATH/mount.*'.
/usr/local/share/fish/functions/__fish_print_filesystems.fish (line 1): string replace -ra ".*/mount." "" -- $PATH/mount.*
                                                                                                             ^
in command substitution
	called on line 1 of file /usr/local/share/fish/functions/__fish_print_filesystems.fish

in function '__fish_print_filesystems'
	called on standard input

in command substitution
	called on standard input
Comment 1 Alan Somers freebsd_committer freebsd_triage 2017-01-13 15:57:48 UTC
Created attachment 178862 [details]
Fix __fish__print__filesystems.fish

Please try this patch.
Comment 2 Alan Somers freebsd_committer freebsd_triage 2017-01-17 21:27:27 UTC
Maxfx, Have you had a chance to test it yet?  It fixes the issue for me.
Comment 3 Martin Filla 2017-01-18 18:33:59 UTC
Thanks you very much for patch. Patch is great and function.
Comment 4 Alan Somers freebsd_committer freebsd_triage 2017-01-21 17:15:14 UTC
We can't close the bug yet, MaxFx, because the fix has not been committed.
Comment 5 commit-hook freebsd_committer freebsd_triage 2017-02-09 00:11:03 UTC
A commit references this bug:

Author: asomers
Date: Thu Feb  9 00:09:59 UTC 2017
New revision: 433701
URL: https://svnweb.freebsd.org/changeset/ports/433701

Log:
  Fix two bugs in shells/fish

  1) The build would fail when DOCS=off (PR 216167)
  2) Tab completion doesn't work for "mount -t" (PR 216032)

  PR:	216167
  PR:	216032
  Reported by:	Maxfx <maficccc@gmail.com>
  Reported by:	David Guyot <david.guyot@europecamions-interactive.com>
  Approved by:	brd (ports)

Changes:
  head/shells/fish/Makefile
  head/shells/fish/files/extra-patch-Makefile.in
  head/shells/fish/files/patch-share_functions_____fish__print__filesystems.fish