Bug 216052
Created attachment 179050 [details]
clang4 build patch
Created attachment 179051 [details]
Improved pkg-plist
Replaces @exec with @pre/postexec
A commit references this bug: Author: jbeich Date: Wed Jan 18 21:34:42 UTC 2017 New revision: 431828 URL: https://svnweb.freebsd.org/changeset/ports/431828 Log: comms/telldus-core: unbreak with clang 4.0 service/SettingsConfuse.cpp:47:13: error: ordered comparison between pointer and zero ('cfg_t *' and 'int') if (d->cfg > 0) { ~~~~~~ ^ ~ service/SettingsConfuse.cpp:50:17: error: ordered comparison between pointer and zero ('cfg_t *' and 'int') if (d->var_cfg > 0) { ~~~~~~~~~~ ^ ~ service/SettingsConfuse.cpp:61:13: error: ordered comparison between pointer and zero ('cfg_t *' and 'int') if (d->cfg > 0) { ~~~~~~ ^ ~ service/SettingsConfuse.cpp:73:13: error: ordered comparison between pointer and zero ('cfg_t *' and 'int') if (d->cfg > 0) { ~~~~~~ ^ ~ PR: 216052 Submitted by: Johan Str?m (maintainer) Changes: head/comms/telldus-core/files/patch-service-SettingsConfuse.cpp Comment on attachment 179051 [details]
Improved pkg-plist
Can you move this into a separate bug? I can't review this atm but...
- install -d is redundant with @dir
- @* keywords can set mode and owner, see /usr/ports/CHANGES from 20140922
- why not @sample empty vendor config instead of @*exec it from scratch
Note, @sample is implemented by /usr/ports/Keywords/sample.ucl
A commit references this bug: Author: jbeich Date: Thu Jan 19 05:21:23 UTC 2017 New revision: 431845 URL: https://svnweb.freebsd.org/changeset/ports/431845 Log: MFH: r431828 comms/telldus-core: unbreak with clang 4.0 service/SettingsConfuse.cpp:47:13: error: ordered comparison between pointer and zero ('cfg_t *' and 'int') if (d->cfg > 0) { ~~~~~~ ^ ~ service/SettingsConfuse.cpp:50:17: error: ordered comparison between pointer and zero ('cfg_t *' and 'int') if (d->var_cfg > 0) { ~~~~~~~~~~ ^ ~ service/SettingsConfuse.cpp:61:13: error: ordered comparison between pointer and zero ('cfg_t *' and 'int') if (d->cfg > 0) { ~~~~~~ ^ ~ service/SettingsConfuse.cpp:73:13: error: ordered comparison between pointer and zero ('cfg_t *' and 'int') if (d->cfg > 0) { ~~~~~~ ^ ~ PR: 216052 Submitted by: Johan Str?m (maintainer) Approved by: ports-secteam blanket Changes: _U branches/2017Q1/ branches/2017Q1/comms/telldus-core/files/patch-service-SettingsConfuse.cpp Removing myself from bug, telldus-core is fixed. Automated spam? |
service/SettingsConfuse.cpp:47:13: error: ordered comparison between pointer and zero ('cfg_t *' and 'int') if (d->cfg > 0) { ~~~~~~ ^ ~ service/SettingsConfuse.cpp:50:17: error: ordered comparison between pointer and zero ('cfg_t *' and 'int') if (d->var_cfg > 0) { ~~~~~~~~~~ ^ ~ service/SettingsConfuse.cpp:61:13: error: ordered comparison between pointer and zero ('cfg_t *' and 'int') if (d->cfg > 0) { ~~~~~~ ^ ~ service/SettingsConfuse.cpp:73:13: error: ordered comparison between pointer and zero ('cfg_t *' and 'int') if (d->cfg > 0) { ~~~~~~ ^ ~ build log: http://sprunge.us/ZeWh regressed by: https://github.com/llvm-mirror/clang/commit/4b6ad14285f3