Bug 216072

Summary: games/vegastrike: fails to build with clang 4.0
Product: Ports & Packages Reporter: Jan Beich <jbeich>
Component: Individual Port(s)Assignee: Jan Beich <jbeich>
Status: Closed FIXED    
Severity: Affects Only Me Keywords: needs-patch
Priority: ---    
Version: Latest   
Hardware: Any   
OS: Any   
See Also: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216016
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=215861
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216015
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216046
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216051
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216052
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216056
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216058
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216019
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216074
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216075
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216076
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216159
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216176
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216194
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216197
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216198
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216199
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216200
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216203
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216206
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216211
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216213
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216214
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216215
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216216
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216217
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216218
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216221
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216222
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216227
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216228
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216233
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216234
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216235
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216253
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216354
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216355
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216356
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216357
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216358
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216615
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216617
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216618
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216619
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216620
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216621
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216622
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216623
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216624
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216626
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216627
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216629
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216630
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216631
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216632
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216633
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216634
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216635
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216636
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216637
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216638
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216639
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216640
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216641
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216642
Bug Depends on:    
Bug Blocks: 216008    

Description Jan Beich freebsd_committer freebsd_triage 2017-01-14 15:55:18 UTC
games/vegastrike: fails to build with clang 4.0

setup/src/include/central.cpp:37:37: error: ordered comparison between pointer and zero ('struct group *' and 'int')
        } while ((CURRENT = CURRENT->next) > 0);
                 ~~~~~~~~~~~~~~~~~~~~~~~~~ ^ ~
setup/src/include/central.cpp:45:37: error: ordered comparison between pointer and zero ('struct catagory *' and 'int')
        } while ((CURRENT = CURRENT->next) > 0);
                 ~~~~~~~~~~~~~~~~~~~~~~~~~ ^ ~
setup/src/include/central.cpp:57:37: error: ordered comparison between pointer and zero ('struct catagory *' and 'int')
        } while ((CURRENT = CURRENT->next) > 0);
                 ~~~~~~~~~~~~~~~~~~~~~~~~~ ^ ~
setup/src/include/central.cpp:67:29: error: ordered comparison between pointer and zero ('struct group *' and 'int')
        } while ((CUR = CUR->next) > 0);
                 ~~~~~~~~~~~~~~~~~ ^ ~
setup/src/include/central.cpp:77:29: error: ordered comparison between pointer and zero ('struct catagory *' and 'int')
        } while ((CUR = CUR->next) > 0);
                 ~~~~~~~~~~~~~~~~~ ^ ~
setup/src/include/central.cpp:87:36: error: ordered comparison between pointer and zero ('struct group *' and 'int')
        } while ((CUR = CUR->next) > 0);
                 ~~~~~~~~~~~~~~~~~ ^ ~

build log: http://sprunge.us/iBLO
regressed by: https://github.com/llvm-mirror/clang/commit/4b6ad14285f3
Comment 1 commit-hook freebsd_committer freebsd_triage 2017-02-01 05:27:10 UTC
A commit references this bug:

Author: jbeich
Date: Wed Feb  1 05:25:55 UTC 2017
New revision: 432972
URL: https://svnweb.freebsd.org/changeset/ports/432972

Log:
  games/vegastrike: unbreak with clang 4.0

  setup/src/include/central.cpp:37:37: error: ordered comparison between pointer and zero
        ('struct group *' and 'int')
          } while ((CURRENT = CURRENT->next) > 0);
                   ~~~~~~~~~~~~~~~~~~~~~~~~~ ^ ~
  setup/src/include/central.cpp:45:37: error: ordered comparison between pointer and zero
        ('struct catagory *' and 'int')
          } while ((CURRENT = CURRENT->next) > 0);
                   ~~~~~~~~~~~~~~~~~~~~~~~~~ ^ ~
  setup/src/include/central.cpp:57:37: error: ordered comparison between pointer and zero
        ('struct catagory *' and 'int')
          } while ((CURRENT = CURRENT->next) > 0);
                   ~~~~~~~~~~~~~~~~~~~~~~~~~ ^ ~
  setup/src/include/central.cpp:67:29: error: ordered comparison between pointer and zero
        ('struct group *' and 'int')
          } while ((CUR = CUR->next) > 0);
                   ~~~~~~~~~~~~~~~~~ ^ ~
  setup/src/include/central.cpp:77:29: error: ordered comparison between pointer and zero
        ('struct catagory *' and 'int')
          } while ((CUR = CUR->next) > 0);
                   ~~~~~~~~~~~~~~~~~ ^ ~
  setup/src/include/central.cpp:87:36: error: ordered comparison between pointer and zero
        ('struct group *' and 'int')
          } while ((CUR = CUR->next) > 0);
                   ~~~~~~~~~~~~~~~~~ ^ ~
  setup/src/include/display_gtk.cpp:112:36: error: ordered comparison between pointer and zero
        ('catagory *' and 'int')
                  } while ((NEWCUR = NEWCUR->next) > 0);
                           ~~~~~~~~~~~~~~~~~~~~~~~ ^ ~
  setup/src/include/display_gtk.cpp:127:37: error: ordered comparison between pointer and zero
        ('struct group *' and 'int')
          } while ((CURRENT = CURRENT->next) > 0);
                   ~~~~~~~~~~~~~~~~~~~~~~~~~ ^ ~
  setup/src/include/display_gtk.cpp:183:29: error: ordered comparison between pointer and zero
        ('struct catagory *' and 'int')
          } while ((CUR = CUR->next) > 0);
                   ~~~~~~~~~~~~~~~~~ ^ ~
  setup/src/include/file.cpp:170:52: error: ordered comparison between pointer and zero
        ('char *' and 'int')
              while ( ( n_parm = next_parm( parm ) ) > 0 ) {
                      ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^ ~
  setup/src/include/file.cpp:191:52: error: ordered comparison between pointer and zero
        ('char *' and 'int')
              while ( ( n_parm = next_parm( parm ) ) > 0 ) {
                      ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^ ~
  setup/src/include/file.cpp:321:52: error: ordered comparison between pointer and zero
        ('char *' and 'int')
              while ( ( n_parm = next_parm( parm ) ) > 0 ) {
                      ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^ ~
  setup/src/include/general.cpp:124:46: error: ordered comparison between pointer and zero
        ('char *' and 'int')
          while ((location = strstr(current, search)) > 0) {
                 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^ ~

  PR:		216072
  Reported by:	antoine (via exp-run)

Changes:
  head/games/vegastrike/files/patch-clang40