Summary: | [ipfw] [panic] stable/11: repeating KASSERT("rm_rlock: recursed on non-recursive rmlock") crash | ||||||
---|---|---|---|---|---|---|---|
Product: | Base System | Reporter: | Eugene Grosbein <ports> | ||||
Component: | kern | Assignee: | Andrey V. Elsukov <ae> | ||||
Status: | Closed FIXED | ||||||
Severity: | Affects Some People | CC: | ae, glebius | ||||
Priority: | --- | ||||||
Version: | 11.0-STABLE | ||||||
Hardware: | Any | ||||||
OS: | Any | ||||||
Attachments: |
|
Description
Eugene Grosbein
2017-01-17 10:08:31 UTC
A commit references this bug: Author: ae Date: Tue Jan 17 10:50:28 UTC 2017 New revision: 312341 URL: https://svnweb.freebsd.org/changeset/base/312341 Log: Initialize IPFW static rules rmlock with RM_RECURSE flag. This lock was replaced from rwlock in r272840. But unlike rwlock, rmlock doesn't allow recursion on rm_rlock(), so at this time fix this with RM_RECURSE flag. Later we need to change ipfw to avoid such recursions. PR: 216171 Reported by: Eugene Grosbein MFC after: 1 week Changes: head/sys/netpfil/ipfw/ip_fw_private.h Gleb, what you think, is it a candidate for errata? (In reply to commit-hook from comment #1) Thanks, this fix really solves the problem. A commit references this bug: Author: ae Date: Tue Jan 24 00:38:35 UTC 2017 New revision: 312677 URL: https://svnweb.freebsd.org/changeset/base/312677 Log: MFC r312341: Initialize IPFW static rules rmlock with RM_RECURSE flag. This lock was replaced from rwlock in r272840. But unlike rwlock, rmlock doesn't allow recursion on rm_rlock(), so at this time fix this with RM_RECURSE flag. Later we need to change ipfw to avoid such recursions. PR: 216171 Changes: _U stable/11/ stable/11/sys/netpfil/ipfw/ip_fw_private.h |