Bug 216176
Created attachment 179192 [details] upstream commit This has been fixed upstream https://sourceforge.net/p/fluxbox/bugs/1138/ with http://git.fluxbox.org/fluxbox.git/commit/util/fluxbox-remote.cc?id=22866c4d30f5b289c429c5ca88d800200db4fc4f Comment on attachment 179192 [details] upstream commit Upstream commit message looks cryptic. Since this affects just one file, reformat it via "make makepatch" then paste the link to the bug and commit at the top. The fix itself looks innocuous enough to land under "portmgr blanket" + "ports-secteam blanket" (to 2017Q1) without bumping PORTREVISION. I confirm it's enough to unbreak build on clang400-import@312309 i386: http://sprunge.us/CfKH Created attachment 179194 [details]
regenerated patch
Comment on attachment 179194 [details]
regenerated patch
Looks OK now.
A commit references this bug: Author: tcberner Date: Sat Jan 21 22:14:23 UTC 2017 New revision: 432090 URL: https://svnweb.freebsd.org/changeset/ports/432090 Log: Fix graphics/py-poppler-qt4: fails to build with clang 4.0 Import upstream commit http://git.fluxbox.org/fluxbox.git/commit/util/fluxbox-remote.cc?id=22866c4d30f5b289c429c5ca88d800200db4fc4f for issue https://sourceforge.net/p/fluxbox/bugs/1138/ PR: 216176 Approved by: portmgr blanket, rakuco (mentor) MFH: 2017Q1 Changes: head/x11-wm/fluxbox/files/patch-util_fluxbox-remote.cc A commit references this bug: Author: tcberner Date: Sun Jan 22 12:57:04 UTC 2017 New revision: 432129 URL: https://svnweb.freebsd.org/changeset/ports/432129 Log: MFH: r432090 Fix x11-wm/fluxbox: fails to build with clang 4.0 Import upstream commit http://git.fluxbox.org/fluxbox.git/commit/util/fluxbox-remote.cc?id=22866c4d30f5b289c429c5ca88d800200db4fc4f for issue https://sourceforge.net/p/fluxbox/bugs/1138/ PR: 216176 Approved by: portmgr blanket, rakuco (mentor) Approved by: ports-secteam (junovitch), rakuco (mentor) Changes: _U branches/2017Q1/ branches/2017Q1/x11-wm/fluxbox/files/patch-util_fluxbox-remote.cc |
util/fluxbox-remote.cc:76:32: error: ordered comparison between pointer and zero ('unsigned char *' and 'int') && text_prop.value > 0 ~~~~~~~~~~~~~~~ ^ ~ build log: http://sprunge.us/YOgf regressed by: https://github.com/llvm-mirror/clang/commit/4b6ad14285f3