Bug 216187

Summary: www/nextcloud Remove net/pecl-smbclient dependency
Product: Ports & Packages Reporter: johnllyon
Component: Individual Port(s)Assignee: Bernard Spil <brnrd>
Status: Closed FIXED    
Severity: Affects Many People CC: arved, brnrd, kevlo, loic.blot, w.schwarzenfeld
Priority: --- Keywords: needs-patch
Version: Latest   
Hardware: Any   
OS: Any   

Description johnllyon 2017-01-17 17:15:21 UTC
It would be best to remove the hard dependency for net/pecl-smbclient for two reasons.  First, it depends on an outdated and deprecated version of libsmbclient (3.6.25).  Second, Nextcloud's documentation provides two alternatives that are preferred (see https://docs.nextcloud.com/server/10/admin_manual/configuration_files/external_storage/smb.html)

The first option is to replace net/pecl-smbclient with PHP's smbclient module.  This would probably be preferred because it's a lighter weight solution than installing the entire samba suite.  However, I have not seen a port of PHP's smbclient module in the ports tree.

The second option is install the samba suite as a dependency (or rely on an already installed version of samba) instead of net/pecl-smbclient.  I have tested this and can verify that it works.  I installed samba43 from ports and then manually installed nextcloud 11.0.1.  Nextcloud automatically used the command line client "smbclient" installed by the samba43 port for connecting to SMB/CIFS external storage.  I also remember that the old owncloud 9.0 port allowed this (i.e. if samba was already installed, it would use it), so it should be doable.
Comment 1 Bernard Spil freebsd_committer freebsd_triage 2018-03-31 13:35:55 UTC
Hi John,

Is this still an issue? The pecl port now depends on a properly supported Samba version 4.6.

We can still debate if this should be a default-on or default-off option.

Cheers, Bernard.
Comment 2 commit-hook freebsd_committer freebsd_triage 2018-04-27 08:18:35 UTC
A commit references this bug:

Author: brnrd
Date: Fri Apr 27 08:17:30 UTC 2018
New revision: 468405
URL: https://svnweb.freebsd.org/changeset/ports/468405

Log:
  www/nextcloud: Update to 13.0.2

   - SMB option now default OFF [1,2]

  PR:		227510 [1], 216187 [2]
  Reported by:	Ilkka Tengvall <ilkka tengvall iki fi> [1]
  Reported by:	johnllyon gmail com [2]

Changes:
  head/www/nextcloud/Makefile
  head/www/nextcloud/distinfo
  head/www/nextcloud/pkg-plist