Summary: | multimedia/libvpx: grab and drop architecture whitelist | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | Ports & Packages | Reporter: | Jan Beich <jbeich> | ||||||
Component: | Individual Port(s) | Assignee: | Jan Beich <jbeich> | ||||||
Status: | Closed FIXED | ||||||||
Severity: | Affects Only Me | CC: | ashish, mikael | ||||||
Priority: | --- | Keywords: | patch | ||||||
Version: | Latest | Flags: | ashish:
maintainer-feedback+
|
||||||
Hardware: | Any | ||||||||
OS: | Any | ||||||||
Attachments: |
|
Description
Jan Beich
![]() ![]() Comment on attachment 179003 [details]
v0
bsd.cpu.mk has some magic for armv6, so folks should use CPUTYPE=cortexa or similar than passing -march to CFLAGS directly. I'm not sure if we actually support armv8 on armv6 or it requires aarch32 target added in src/.
Comment on attachment 179003 [details] v0 > -+ASFLAGS+=-I$(BUILD_PFX)$(BUILD_ROOT)/ -I$(SRC_PATH)/ -meabi=5 Oops, removing this was premature. /usr/bin/ld: ERROR: Source object vpx_dsp/arm/intrapred_neon_asm.asm.S.o has EABI version 0, but target libvpx.so.4.1.0 has EABI version 5 /usr/bin/ld: failed to merge target specific data of file vpx_dsp/arm/intrapred_neon_asm.asm.S.o /usr/bin/ld: ERROR: Source object vpx_dsp/arm/vpx_convolve_copy_neon_asm.asm.S.o has EABI version 0,but target libvpx.so.4.1.0 has EABI version 5 /usr/bin/ld: failed to merge target specific data of file vpx_dsp/arm/vpx_convolve_copy_neon_asm.asm.S.o Created attachment 179005 [details]
v0.1
(In reply to Jan Beich (mail not working) from comment #3) Howdy! I'm able to test it on AMD64 platform, where it seems to build as expected. Also, thanks for taking the maintainership, you have my approval. Please go ahead, and commit. Thanks! A commit references this bug: Author: jbeich Date: Sun Jan 22 09:03:56 UTC 2017 New revision: 432101 URL: https://svnweb.freebsd.org/changeset/ports/432101 Log: multimedia/libvpx: grab and drop architecture whitelist PR: 216191 Approved by: ashish (previous maintainer) MFH: 2017Q1 Changes: head/multimedia/libvpx/Makefile head/multimedia/libvpx/files/extra-patch-build_make_Makefile head/multimedia/libvpx/files/patch-configure A commit references this bug: Author: jbeich Date: Sun Jan 22 09:07:04 UTC 2017 New revision: 432102 URL: https://svnweb.freebsd.org/changeset/ports/432102 Log: MFH: r432101 multimedia/libvpx: grab and drop architecture whitelist PR: 216191 Approved by: ashish (previous maintainer) Approved by: ports-secteam blanket (unbreaks armv6 after r431741) Changes: _U branches/2017Q1/ branches/2017Q1/multimedia/libvpx/Makefile branches/2017Q1/multimedia/libvpx/files/extra-patch-build_make_Makefile branches/2017Q1/multimedia/libvpx/files/patch-configure |